Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-11 Thread Francesco Romani
- Original Message - From: Peter Krempa pkre...@redhat.com To: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Tuesday, September 9, 2014 1:56:09 PM Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group + * VIR_DOMAIN_STATS_VCPU: Return

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-11 Thread Peter Krempa
On 09/11/14 17:54, Francesco Romani wrote: - Original Message - From: Peter Krempa pkre...@redhat.com To: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Tuesday, September 9, 2014 1:56:09 PM Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-11 Thread Francesco Romani
- Original Message - From: Peter Krempa pkre...@redhat.com To: Francesco Romani from...@redhat.com, libvir-list@redhat.com Sent: Thursday, September 11, 2014 6:07:48 PM Subject: Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group I like this, but I'd also need to do

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-10 Thread Wang Rui
On 2014/9/9 19:56, Peter Krempa wrote: + * VIR_DOMAIN_STATS_VCPU: Return virtual CPU statistics. + * Due to VCPU hotplug, the vcpu.num.* array could be sparse. + * The actual size of the array correspond to vcpu.current. + * The array size will never exceed vcpu.maximum. + * The typed

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-10 Thread Wang Rui
On 2014/9/8 21:05, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. To do so, this patch also extracts a helper to gather the VCpu information. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 +

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-10 Thread Francesco Romani
+static int +qemuDomainGetStatsVcpu(virConnectPtr conn ATTRIBUTE_UNUSED, + virDomainObjPtr dom, + virDomainStatsRecordPtr record, + int *maxparams, + unsigned int privflags ATTRIBUTE_UNUSED) +{

Re: [libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-09 Thread Peter Krempa
On 09/08/14 15:05, Francesco Romani wrote: This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. To do so, this patch also extracts a helper to gather the VCpu information. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 +

[libvirt] [PATCHv3 4/8] qemu: bulk stats: implement VCPU group

2014-09-08 Thread Francesco Romani
This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. To do so, this patch also extracts a helper to gather the VCpu information. Signed-off-by: Francesco Romani from...@redhat.com --- include/libvirt/libvirt.h.in | 1 + src/libvirt.c| 13 +++