Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-23 Thread Andrea Bolognani
On Mon, 2018-07-23 at 10:27 +0100, Daniel P. Berrangé wrote: > On Mon, Jul 23, 2018 at 09:38:47AM +0200, Andrea Bolognani wrote: > > Partially answering myself (morning coffee hasn't quite kicked in > > just yet), the MinGW .spec doesn't list yajl as a BuildRequires, > > which means that either

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-23 Thread Daniel P . Berrangé
On Mon, Jul 23, 2018 at 09:38:47AM +0200, Andrea Bolognani wrote: > On Mon, 2018-07-23 at 09:27 +0200, Andrea Bolognani wrote: > > On Fri, 2018-07-20 at 11:33 +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > > > > I do not oppose reverting this

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-23 Thread Andrea Bolognani
On Mon, 2018-07-23 at 09:27 +0200, Andrea Bolognani wrote: > On Fri, 2018-07-20 at 11:33 +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > > > I do not oppose reverting this bit and failing by default if we don't > > > have a JSON library (as Andrea

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-23 Thread Andrea Bolognani
On Fri, 2018-07-20 at 11:33 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > > I do not oppose reverting this bit and failing by default if we don't > > have a JSON library (as Andrea mentioned, more drivers might possibly > > require a working JSON

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-20 Thread Daniel P . Berrangé
On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > On Thu, Jul 19, 2018 at 07:38:15PM -0400, John Ferlan wrote: > > > > > > On 07/18/2018 10:44 AM, Ján Tomko wrote: > > > Unless explicitly requested, enable the QEMU driver > > > only if the Jansson library is present. > > > > > >

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-20 Thread Ján Tomko
On Thu, Jul 19, 2018 at 07:38:15PM -0400, John Ferlan wrote: On 07/18/2018 10:44 AM, Ján Tomko wrote: Unless explicitly requested, enable the QEMU driver only if the Jansson library is present. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 6 +- 1 file changed, 5 insertions(+),

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-19 Thread John Ferlan
On 07/18/2018 10:44 AM, Ján Tomko wrote: > Unless explicitly requested, enable the QEMU driver > only if the Jansson library is present. > > Signed-off-by: Ján Tomko > --- > m4/virt-driver-qemu.m4 | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Perhaps it's obvious for

[libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

2018-07-18 Thread Ján Tomko
Unless explicitly requested, enable the QEMU driver only if the Jansson library is present. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 index 80e1d3ad46..ddb2834705