Re: [libvirt] [PATCHv4 4/4] snapshot: qemu: Implement reverting of external snapshots

2012-11-21 Thread Peter Krempa
On 11/21/12 01:37, Eric Blake wrote: On 11/19/2012 04:51 PM, Eric Blake wrote: On 11/19/2012 09:06 AM, Peter Krempa wrote: This patch adds support for reverting of external snapshots. The support is somewhat limited yet (you can only revert to a snapshot that has no children or delete the

Re: [libvirt] [PATCHv4 4/4] snapshot: qemu: Implement reverting of external snapshots

2012-11-21 Thread Eric Blake
On 11/21/2012 07:16 AM, Peter Krempa wrote: +/* wipe and re-create disk images - qemu-img doesn't care if it exists*/ +if (qemuDomainSnapshotCreateInactiveExternal(driver, vm, snap, false) 0) +goto endjob; This comment says you are throwing away state, but without the use

Re: [libvirt] [PATCHv4 4/4] snapshot: qemu: Implement reverting of external snapshots

2012-11-20 Thread Eric Blake
On 11/19/2012 04:51 PM, Eric Blake wrote: On 11/19/2012 09:06 AM, Peter Krempa wrote: This patch adds support for reverting of external snapshots. The support is somewhat limited yet (you can only revert to a snapshot that has no children or delete the children that would have their image

[libvirt] [PATCHv4 4/4] snapshot: qemu: Implement reverting of external snapshots

2012-11-19 Thread Peter Krempa
This patch adds support for reverting of external snapshots. The support is somewhat limited yet (you can only revert to a snapshot that has no children or delete the children that would have their image chains invalidated). While reverting an external snapshot, the domain has to be taken offline

Re: [libvirt] [PATCHv4 4/4] snapshot: qemu: Implement reverting of external snapshots

2012-11-19 Thread Eric Blake
On 11/19/2012 09:06 AM, Peter Krempa wrote: This patch adds support for reverting of external snapshots. The support is somewhat limited yet (you can only revert to a snapshot that has no children or delete the children that would have their image chains invalidated). While reverting an