Re: [libvirt] [PATCHv5 12/23] blockjob: relax block job behavior when setting speed up front

2012-04-19 Thread Eric Blake
On 04/19/2012 03:00 PM, Jiri Denemark wrote: > On Mon, Apr 16, 2012 at 23:06:03 -0600, Eric Blake wrote: >> In qemu, it is possible to call 'migrate_set_speed' prior to >> 'migrate', and therefore ensure a constant throttling through the >> entire migration. However, this is not possible with >> '

Re: [libvirt] [PATCHv5 12/23] blockjob: relax block job behavior when setting speed up front

2012-04-19 Thread Jiri Denemark
On Mon, Apr 16, 2012 at 23:06:03 -0600, Eric Blake wrote: > In qemu, it is possible to call 'migrate_set_speed' prior to > 'migrate', and therefore ensure a constant throttling through the > entire migration. However, this is not possible with > 'block-job-set-speed', which fails if a job is not a

[libvirt] [PATCHv5 12/23] blockjob: relax block job behavior when setting speed up front

2012-04-16 Thread Eric Blake
In qemu, it is possible to call 'migrate_set_speed' prior to 'migrate', and therefore ensure a constant throttling through the entire migration. However, this is not possible with 'block-job-set-speed', which fails if a job is not already active. This means that you can't detect a device that does