Coverity has found a RESOURCE_LEAK...
...snip...
+static int
+virStorageFileBackendGlusterInit(virStorageFilePtr file)
+{
+virStorageFileBackendGlusterPrivPtr priv = NULL;
+virDomainDiskHostDefPtr host = (file-hosts[0]);
+const char *hostname = host-name;
+int port = 0;
+
On 02/14/14 12:24, John Ferlan wrote:
...
+error:
+VIR_FREE(priv-volname);
+glfs_fini(priv-vol);
Adding the free here would be the salve for Coverity.
Thanks for reporting the issue. This is now fixed by commit
commit ad95fa59572c99c26959e6808a1e779a4ffed6de
Author: Peter Krempa
Implement storage backend functions to deal with gluster volumes and
implement the stat and unlink backend APIs.
---
Notes:
Version 6:
- tweaked error message style
- tweak of private data access due to simplification of export hierarchy
Version 5:
- adapted to error
On 02/13/2014 09:49 AM, Peter Krempa wrote:
Implement storage backend functions to deal with gluster volumes and
implement the stat and unlink backend APIs.
---
Notes:
Version 6:
- tweaked error message style
- tweak of private data access due to simplification of export