Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-14 Thread Luiz Capitulino
On Wed, 13 Jun 2012 18:07:43 -0400 Corey Bryant wrote: > > > On 06/13/2012 04:47 PM, Eric Blake wrote: > > On 06/13/2012 02:25 PM, Corey Bryant wrote: > > > >>> Also, getfd automatically closes a fd if an existing fdname is passed > >>> again. > >>> I don't think this is a good behavior, I thin

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-13 Thread Corey Bryant
On 06/13/2012 04:47 PM, Eric Blake wrote: On 06/13/2012 02:25 PM, Corey Bryant wrote: Also, getfd automatically closes a fd if an existing fdname is passed again. I don't think this is a good behavior, I think pass-fd should fail instead (note that we can't fix getfd though). I agree. It

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-13 Thread Eric Blake
On 06/13/2012 02:25 PM, Corey Bryant wrote: >> Also, getfd automatically closes a fd if an existing fdname is passed >> again. >> I don't think this is a good behavior, I think pass-fd should fail >> instead >> (note that we can't fix getfd though). >> > > I agree. It makes sense to fail rather

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-13 Thread Corey Bryant
On 06/13/2012 03:46 PM, Luiz Capitulino wrote: On Fri, 8 Jun 2012 11:42:57 -0400 Corey Bryant wrote: This patch adds the passfd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the passfd command also returns the re

Re: [libvirt] [Qemu-devel] [PATCH v2 2/4] qapi: Add passfd QMP command

2012-06-13 Thread Luiz Capitulino
On Fri, 8 Jun 2012 11:42:57 -0400 Corey Bryant wrote: > This patch adds the passfd QMP command using the QAPI framework. > Like the getfd command, it is used to pass a file descriptor via > SCM_RIGHTS. However, the passfd command also returns the received > file descriptor, which is a differenc