Re: [libvirt] [REPOST PATCHv2 2/2] qemu: Use the correct vm def on cold attach

2018-07-13 Thread Michal Privoznik
On 07/13/2018 02:50 PM, John Ferlan wrote: > > > On 07/09/2018 10:32 AM, Michal Privoznik wrote: >> On 07/06/2018 08:50 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867 >>> >>> When attaching a device to the domain we need to be sure >>> to use the correct domain

Re: [libvirt] [REPOST PATCHv2 2/2] qemu: Use the correct vm def on cold attach

2018-07-13 Thread John Ferlan
On 07/09/2018 10:32 AM, Michal Privoznik wrote: > On 07/06/2018 08:50 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1559867 >> >> When attaching a device to the domain we need to be sure >> to use the correct domain definition (vm->def or vm->newDef) >> when calling

Re: [libvirt] [REPOST PATCHv2 2/2] qemu: Use the correct vm def on cold attach

2018-07-09 Thread Michal Privoznik
On 07/06/2018 08:50 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1559867 > > When attaching a device to the domain we need to be sure > to use the correct domain definition (vm->def or vm->newDef) > when calling virDomainDeviceDefParse because the post parse > processing

[libvirt] [REPOST PATCHv2 2/2] qemu: Use the correct vm def on cold attach

2018-07-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1559867 When attaching a device to the domain we need to be sure to use the correct domain definition (vm->def or vm->newDef) when calling virDomainDeviceDefParse because the post parse processing algorithms that may assign an address for the device