Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-20 Thread Daniel Veillard
On Wed, May 20, 2009 at 12:27:58AM +0900, Ryota Ozaki wrote: > Apologies for not responding. I've come down with a cold > (not flu) for several days... > > On Tue, May 19, 2009 at 10:34 PM, Daniel Veillard wrote: [...] > >  Just to make sure, this is not ready, right ? > > We freeze for libvirt-0

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-19 Thread Ryota Ozaki
Apologies for not responding. I've come down with a cold (not flu) for several days... On Tue, May 19, 2009 at 10:34 PM, Daniel Veillard wrote: > On Mon, May 11, 2009 at 06:01:07PM +0900, Ryota Ozaki wrote: >> Hi, >> I've updated the patch. The change includes support for multiple mount >> points

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-19 Thread Daniel Veillard
On Mon, May 11, 2009 at 06:01:07PM +0900, Ryota Ozaki wrote: > Hi, > I've updated the patch. The change includes support for multiple mount > points of cgroups that I didn't cope with in the previous patch. > > Through the work, I found a bit messy problem. Current lxc controller writes > pid in a

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-16 Thread Serge E. Hallyn
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > I've updated the patch. The change includes support for multiple mount > points of cgroups that I didn't cope with in the previous patch. > > Through the work, I found a bit messy problem. Current lxc controller writes > pid in a 'tasks' file multiple

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-11 Thread Ryota Ozaki
Hi, On Mon, May 11, 2009 at 10:26 AM, Ryota Ozaki wrote: > Hi, > > On Sun, May 10, 2009 at 8:49 AM, Ryota Ozaki wrote: >> Hi Serge and Daniel, >> >> On Sat, May 9, 2009 at 4:03 AM, Serge E. Hallyn wrote: >>> Quoting Daniel P. Berrange (berra...@redhat.com): On Fri, May 08, 2009 at 08:34:12

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-10 Thread Ryota Ozaki
Hi, On Sun, May 10, 2009 at 8:49 AM, Ryota Ozaki wrote: > Hi Serge and Daniel, > > On Sat, May 9, 2009 at 4:03 AM, Serge E. Hallyn wrote: >> Quoting Daniel P. Berrange (berra...@redhat.com): >>> On Fri, May 08, 2009 at 08:34:12AM -0500, Serge E. Hallyn wrote: >>> > Quoting Ryota Ozaki (ozaki.ry.

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-09 Thread Ryota Ozaki
Hi Serge and Daniel, On Sat, May 9, 2009 at 4:03 AM, Serge E. Hallyn wrote: > Quoting Daniel P. Berrange (berra...@redhat.com): >> On Fri, May 08, 2009 at 08:34:12AM -0500, Serge E. Hallyn wrote: >> > Quoting Ryota Ozaki (ozaki.ry...@gmail.com): >> > > Hi Serge, >> > > >> > > On Fri, May 8, 2009

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-08 Thread Serge E. Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): > On Fri, May 08, 2009 at 08:34:12AM -0500, Serge E. Hallyn wrote: > > Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > > > Hi Serge, > > > > > > On Fri, May 8, 2009 at 11:48 AM, Serge E. Hallyn wrote: > > > > IIUC, the real problem is that src/cgro

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-08 Thread Daniel P. Berrange
On Fri, May 08, 2009 at 08:34:12AM -0500, Serge E. Hallyn wrote: > Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > > Hi Serge, > > > > On Fri, May 8, 2009 at 11:48 AM, Serge E. Hallyn wrote: > > > IIUC, the real problem is that src/cgroup.c assumes that the > > > cgroup name should be $CGROUP_MOUN

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-08 Thread Serge E. Hallyn
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > Hi Serge, > > On Fri, May 8, 2009 at 11:48 AM, Serge E. Hallyn wrote: > > IIUC, the real problem is that src/cgroup.c assumes that the > > cgroup name should be $CGROUP_MOUNTPOINT/groupname.  But of > > course if the ns cgroup is enabled, then the un

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-07 Thread Ryota Ozaki
Hi Serge, On Fri, May 8, 2009 at 11:48 AM, Serge E. Hallyn wrote: > IIUC, the real problem is that src/cgroup.c assumes that the > cgroup name should be $CGROUP_MOUNTPOINT/groupname.  But of > course if the ns cgroup is enabled, then the unshare(CLONE_NEWNS) > to create a new namespace in which t

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-07 Thread Serge E. Hallyn
IIUC, the real problem is that src/cgroup.c assumes that the cgroup name should be $CGROUP_MOUNTPOINT/groupname. But of course if the ns cgroup is enabled, then the unshare(CLONE_NEWNS) to create a new namespace in which to mount the new devpts locks the driver under $CGROUP_MOUNTPOINT// or somesu

[libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-07 Thread Ryota Ozaki
Hi, lxc does not work if ns cgroups subsystem is enabled because of two factors; one is that ns has a special rule to create a group[*] unlike other subsystems and the other is lxc controller creates a new namespace for /dev/pts prior to create a new group for a domain. Unfortunately the new names