Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-04 Thread Pavel Fedin
Hello! > It's just an assert. We have those for various reasons and extra > carefulness cannot hurt. I don't think it needs differentiating > between whether the code is ran in tests or not. It would need differentiating because in tests we should not talk to the real filesystem, while in

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-03 Thread Pavel Fedin
Hello! > The current xmlopt structure has two callbacks in parser > configuration, one for post-parsing of the whole domain XML and one > for device XML. We could add new (optional) callback in this > structure that would be called before other post-parse callbacks, but > still after the xml is

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-03 Thread Martin Kletzander
On Thu, Sep 03, 2015 at 09:51:11AM +0300, Pavel Fedin wrote: Hello! The current xmlopt structure has two callbacks in parser configuration, one for post-parsing of the whole domain XML and one for device XML. We could add new (optional) callback in this structure that would be called before

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-02 Thread Martin Kletzander
On Tue, Sep 01, 2015 at 05:19:39PM -0400, Cole Robinson wrote: On 08/18/2015 05:40 AM, Pavel Fedin wrote: Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks emulator capabilities during domain XML post-parse. However, test suite does not initialize it, therefore a

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-01 Thread Cole Robinson
On 08/18/2015 05:40 AM, Pavel Fedin wrote: > Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks > emulator capabilities during domain XML post-parse. However, test suite > does not initialize it, therefore a condition to skip all checks if there > is no cache supplied was

[libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-08-18 Thread Pavel Fedin
Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks emulator capabilities during domain XML post-parse. However, test suite does not initialize it, therefore a condition to skip all checks if there is no cache supplied was added. This is actually a hack, whose sole purpose is