Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Lei Li
On 11/11/2011 05:50 AM, Adam Litke wrote: Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Eric Blake
On 11/10/2011 03:04 PM, Eric Blake wrote: We still need a v4 respinning this to use virTypedParameter; I can help by posting a patch 1/8 that shows the changes that I think we need in the public interface, but I don't want to spend the time rebasing the entire series. This is more along the li

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Eric Blake
On 11/10/2011 02:50 PM, Adam Litke wrote: Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command '

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Adam Litke
Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command 'virsh dumpxml' returns the old version. Is

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-09 Thread Lei Li
On 11/10/2011 12:45 PM, Zhi Yong Wu wrote: On Thu, Nov 10, 2011 at 4:32 AM, Lei Li wrote: Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config options support to unify the libvirt API. - Add changes in docs and tests.

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-09 Thread Zhi Yong Wu
On Thu, Nov 10, 2011 at 4:32 AM, Lei Li wrote: > Changes since V2 >  - Implement the Python binding support for setting blkio throttling. >  - Implement --current --live --config options support to unify the libvirt > API. >  - Add changes in docs and tests. >  - Some changes suggested by Adam Li

[libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-09 Thread Lei Li
Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config options support to unify the libvirt API. - Add changes in docs and tests. - Some changes suggested by Adam Litke, Eric Blake, Daniel P. Berrange. - Change the XML sche