Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

2019-04-08 Thread Ján Tomko
On Sat, Apr 06, 2019 at 12:27:09PM +0200, Ilias Stamatis wrote: Στις Σάβ, 6 Απρ 2019 στις 10:10 π.μ., ο/η Ján Tomko έγραψε: The commit summary could be more specific, for example: Guest Domains: fix code example but more importantly, it is missing a Sign-off. See point 6 at

Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

2019-04-06 Thread Ilias Stamatis
Στις Σάβ, 6 Απρ 2019 στις 10:10 π.μ., ο/η Ján Tomko έγραψε: > The commit summary could be more specific, for example: > Guest Domains: fix code example > > but more importantly, it is missing a Sign-off. > See point 6 at https://libvirt.org/hacking.html#patches > Contributors to libvirt

Re: [libvirt] [appdev-guide] [PATCH] fix minor bug in code example

2019-04-06 Thread Ján Tomko
The commit summary could be more specific, for example: Guest Domains: fix code example but more importantly, it is missing a Sign-off. See point 6 at https://libvirt.org/hacking.html#patches Contributors to libvirt projects must assert that they are in compliance with the Developer

[libvirt] [appdev-guide] [PATCH] fix minor bug in code example

2019-04-05 Thread Ilias Stamatis
--- en-US/Guest_Domains.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/en-US/Guest_Domains.xml b/en-US/Guest_Domains.xml index c15bbb8..2a4ef7c 100644 --- a/en-US/Guest_Domains.xml +++ b/en-US/Guest_Domains.xml @@ -88,7 +88,7 @@ dom = virDomainLookupByID(conn, domainID);