Re: [libvirt] [dbus PATCH 1/4] tests: Drop pytest.mark.usefixtures from test_nodedev

2018-08-14 Thread Andrea Bolognani
On Mon, 2018-08-13 at 14:11 +0200, Ján Tomko wrote: > On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote: > > -@pytest.mark.usefixtures("node_device_create") > > class TestNodeDevice(libvirttest.BaseTestClass): > > """ Tests for methods and properties of the NodeDevice interface

Re: [libvirt] [dbus PATCH 1/4] tests: Drop pytest.mark.usefixtures from test_nodedev

2018-08-13 Thread Ján Tomko
On Fri, Jul 27, 2018 at 02:37:38PM +0200, Andrea Bolognani wrote: We're already using node_device_create explicitly for all test cases in order to retrieve the result of the fixture, so using pytest.mark.usefixtures as well is pointless. Additionally, we're soon going to add some test cases

[libvirt] [dbus PATCH 1/4] tests: Drop pytest.mark.usefixtures from test_nodedev

2018-07-27 Thread Andrea Bolognani
We're already using node_device_create explicitly for all test cases in order to retrieve the result of the fixture, so using pytest.mark.usefixtures as well is pointless. Additionally, we're soon going to add some test cases where we need the fixture *not* to run automatically. Signed-off-by: