Re: [libvirt] [dbus PATCH 5/9] util: rename function to follow libvirt naming rules

2017-08-02 Thread John Ferlan
On 08/02/2017 04:35 AM, Pavel Hrdina wrote: > On Tue, Aug 01, 2017 at 09:31:40AM -0400, John Ferlan wrote: >> >> >> On 07/24/2017 09:38 AM, Pavel Hrdina wrote: >>> All libvirt-dbus function should use virtDBus preffix and use only one >>> coding style, camelCase. >>> >> >> s/preffix/prefix >> >>

Re: [libvirt] [dbus PATCH 5/9] util: rename function to follow libvirt naming rules

2017-08-02 Thread Pavel Hrdina
On Tue, Aug 01, 2017 at 09:31:40AM -0400, John Ferlan wrote: > > > On 07/24/2017 09:38 AM, Pavel Hrdina wrote: > > All libvirt-dbus function should use virtDBus preffix and use only one > > coding style, camelCase. > > > > s/preffix/prefix > > In general... Should "bus_path" just be Path -

Re: [libvirt] [dbus PATCH 5/9] util: rename function to follow libvirt naming rules

2017-08-01 Thread John Ferlan
On 07/24/2017 09:38 AM, Pavel Hrdina wrote: > All libvirt-dbus function should use virtDBus preffix and use only one > coding style, camelCase. > s/preffix/prefix In general... Should "bus_path" just be Path - seems redundant to have "virtDBusBus"... It's not wrong, but mainly curious

[libvirt] [dbus PATCH 5/9] util: rename function to follow libvirt naming rules

2017-07-24 Thread Pavel Hrdina
All libvirt-dbus function should use virtDBus preffix and use only one coding style, camelCase. Signed-off-by: Pavel Hrdina --- src/domain.c | 110 +- src/events.c | 20 +-- src/main.c| 2 +-