Re: [libvirt] [jenkins-ci PATCH v2 07/12] lcitool: Implement the 'update' action

2018-07-17 Thread Katerina Koukiou
On Tue, Jul 17, 2018 at 04:45:39PM +0200, Andrea Bolognani wrote: > On Tue, 2018-07-17 at 14:57 +0200, Katerina Koukiou wrote: > > On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote: > > > +cmd = [ "ansible-playbook" ] > > > > IMO this requirement should be as well in python

Re: [libvirt] [jenkins-ci PATCH v2 07/12] lcitool: Implement the 'update' action

2018-07-17 Thread Andrea Bolognani
On Tue, 2018-07-17 at 14:57 +0200, Katerina Koukiou wrote: > On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote: > > +cmd = [ "ansible-playbook" ] > > IMO this requirement should be as well in python requirements file. > In this way you can also specify which ansible version

Re: [libvirt] [jenkins-ci PATCH v2 07/12] lcitool: Implement the 'update' action

2018-07-17 Thread Katerina Koukiou
On Thu, Jul 12, 2018 at 05:19:24PM +0200, Andrea Bolognani wrote: > The 'prepare' alias was kinda redundant and offered > dubious value, so it has been dropped. > > Signed-off-by: Andrea Bolognani > --- > guests/lcitool | 30 ++ > 1 file changed, 30 insertions(+) > >

[libvirt] [jenkins-ci PATCH v2 07/12] lcitool: Implement the 'update' action

2018-07-12 Thread Andrea Bolognani
The 'prepare' alias was kinda redundant and offered dubious value, so it has been dropped. Signed-off-by: Andrea Bolognani --- guests/lcitool | 30 ++ 1 file changed, 30 insertions(+) diff --git a/guests/lcitool b/guests/lcitool index 486f82f..d82c36f 100755 --- a/gu