Re: [libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots

2019-10-08 Thread Fabiano FidĂȘncio
Simon, On Mon, Oct 7, 2019 at 5:30 PM Simon Kobyda wrote: > > Implement snapshot interface and its APIs. > Apart from the comments made by Jano, I'd strongly recommend to have this series rebased atop of Pavel Hrdina's series switching libvirt-dbus to meson. His series is already reviewed and

[libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots

2019-10-07 Thread Simon Kobyda
Implement snapshot interface and its APIs. Simon Kobyda (2): Introduce Domain Snapshot Interface Implement snapshots APIs data/Makefile.am| 1 + data/org.libvirt.Domain.xml | 26 +++ data/org.libvirt.DomainSnapshot.xml | 41 src/Makefile.am