Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-18 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 04:16:30PM +0200, Michal Privoznik wrote: > Well, for some reason, after applying that patch I cannot apply even the > first one (which I could before). It seems like there's a context > mismatch in the syms file libvirt-designer/libvirt-designer.sym. > > If you could repos

Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-18 Thread Michal Privoznik
On 11.04.2013 14:36, Christophe Fergeau wrote: > Hi, > > On Thu, Apr 11, 2013 at 01:33:50PM +0200, Michal Privoznik wrote: >> For some reason this patch cannot be applied cleanly: >> >> >> Applying: Rework disk bus type handling >> error: patch failed: libvirt-designer/libvirt-designer-domain.c:99

Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-11 Thread Christophe Fergeau
Hi, On Thu, Apr 11, 2013 at 01:33:50PM +0200, Michal Privoznik wrote: > For some reason this patch cannot be applied cleanly: > > > Applying: Rework disk bus type handling > error: patch failed: libvirt-designer/libvirt-designer-domain.c:992 > error: libvirt-designer/libvirt-designer-domain.c: p

Re: [libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-11 Thread Michal Privoznik
On 03.04.2013 11:20, Christophe Fergeau wrote: > The current handling of bus types has some issues: > - it assumes that if the design uses a disk controller hanging off > a PCI bus, then it can use virtio, which is not true for > Windows for example unless an additional driver is installed > -

[libvirt] [libvirt-designer 3/3] Rework disk bus type handling

2013-04-03 Thread Christophe Fergeau
The current handling of bus types has some issues: - it assumes that if the design uses a disk controller hanging off a PCI bus, then it can use virtio, which is not true for Windows for example unless an additional driver is installed - it checks for "ide", "sata", "virtio" bus names, but they