Re: [libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:33:51PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > +struct _GVirConfigClockPrivate > > +{ > > +    gboolean unused; > > +}; > > (does it really matter if the struct is empty?) Yes, there's a runtime warning if si

Re: [libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-11 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau wrote: > +struct _GVirConfigClockPrivate > +{ > +    gboolean unused; > +}; (does it really matter if the struct is empty?) > +G_DEFINE_TYPE(GVirConfigClock, gvir_config_clock, GVIR_TYPE_CONFIG_OBJECT); > + > + > +static void gvir_config_cl

[libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |4 ++ libvirt-gconfig/libvirt-gconfig-clock.c | 82 +++ libvirt-gconfig/libvirt-gconfig-clock.h | 68 + libvirt-gconfig/libvirt-gconfig-timer.c | 82 +++ libvirt-g