Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-14 Thread Christophe Fergeau
On Tue, Jul 08, 2014 at 07:41:55PM +0100, Zeeshan Ali (Khattak) wrote: On Mon, Jul 7, 2014 at 12:09 PM, Christophe Fergeau cferg...@redhat.com wrote: This is returning a char * capabilities host cpu modelxxx/model /cpu /host /capabilities while the next patch

Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-14 Thread Zeeshan Ali (Khattak)
On Mon, Jul 14, 2014 at 10:44 AM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Jul 08, 2014 at 07:41:55PM +0100, Zeeshan Ali (Khattak) wrote: On Mon, Jul 7, 2014 at 12:09 PM, Christophe Fergeau cferg...@redhat.com wrote: This is returning a char * capabilities host cpu

Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-14 Thread Christophe Fergeau
On Mon, Jul 14, 2014 at 02:56:18PM +0100, Zeeshan Ali (Khattak) wrote: Ah so you mean that I use the same object to represent both? I'm not sure that makes sense since they are part of different XMLs and therefore different entities. I'm not sure here. We already have GVirConfigDomainCpu which

Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-14 Thread Zeeshan Ali (Khattak)
On Mon, Jul 14, 2014 at 6:31 PM, Christophe Fergeau cferg...@redhat.com wrote: On Mon, Jul 14, 2014 at 02:56:18PM +0100, Zeeshan Ali (Khattak) wrote: Ah so you mean that I use the same object to represent both? I'm not sure that makes sense since they are part of different XMLs and therefore

Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-08 Thread Zeeshan Ali (Khattak)
On Mon, Jul 7, 2014 at 12:09 PM, Christophe Fergeau cferg...@redhat.com wrote: This is returning a char * capabilities host cpu modelxxx/model /cpu /host /capabilities while the next patch exposes the model from the /domain/cpu/model node as an actual object, why the

Re: [libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-07 Thread Christophe Fergeau
This is returning a char * capabilities host cpu modelxxx/model /cpu /host /capabilities while the next patch exposes the model from the /domain/cpu/model node as an actual object, why the difference? Christophe On Fri, Jul 04, 2014 at 02:51:26PM +0100, Zeeshan Ali (Khattak)

[libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

2014-07-04 Thread Zeeshan Ali (Khattak)
Add a method to get the model of the CPU from capabilities. --- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c | 6 ++ libvirt-gconfig/libvirt-gconfig-capabilities-cpu.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym| 2 ++ 3 files changed, 10 insertions(+) diff --git