Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-09 Thread Christophe Fergeau
On Wed, May 09, 2012 at 05:01:25PM +0100, Daniel P. Berrange wrote: > Opps, no I was meaning /domain/cpu/feature here, which is the > same schem as /capabilities/host/cpu/feature. Ah thanks, that clears things up. > > I forgot there was also a /domain/features which corresponds > to /capabilit

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-09 Thread Daniel P. Berrange
On Wed, May 09, 2012 at 05:47:19PM +0200, Christophe Fergeau wrote: > Hi, > > There's still one bit I'm missing, here is my understanding so far: > > On Thu, May 03, 2012 at 12:53:10PM +0100, Daniel P. Berrange wrote: > > On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote: > > Gue

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-09 Thread Christophe Fergeau
Hi, There's still one bit I'm missing, here is my understanding so far: On Thu, May 03, 2012 at 12:53:10PM +0100, Daniel P. Berrange wrote: > On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote: > Guest features (capabilities XML) - these are really just capabilities of > the hyper

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-04 Thread Christophe Fergeau
On Fri, May 04, 2012 at 05:02:37AM +0300, Zeeshan Ali (Khattak) wrote: > On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau > wrote: > > On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: > >> + > >> +    gvir_config_xml_foreach_child(node, add_feature, &data); > > > > gvir_co

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Zeeshan Ali (Khattak)
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau wrote: > On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Not quite complete but its a good start. CUT >> --- >> +/** >> + * gvir_config_capabilities_cpu_get_features: >> + * >> + * G

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote: > On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote: > > On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau > > wrote: > > > What would be these getters apart from the already existing _get_name? > > > > The

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Christophe Fergeau
On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote: > On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau > wrote: > > What would be these getters apart from the already existing _get_name? > > The features under 'guest' can have boolean attributes, 'default' and > 'toggle'. A

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-02 Thread Zeeshan Ali (Khattak)
On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau wrote: > On Wed, May 02, 2012 at 06:35:07PM +0300, Zeeshan Ali (Khattak) wrote: >> On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau >> wrote: >> > Having a per-feature GVirConfigObject seems overkill since it will >> > only be a string wrapper

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-02 Thread Christophe Fergeau
On Wed, May 02, 2012 at 06:35:07PM +0300, Zeeshan Ali (Khattak) wrote: > On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau > wrote: > > Having a per-feature GVirConfigObject seems overkill since it will > > only be a string wrapper, and a GVirConfigObject wrapping just a string > > with no node

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-02 Thread Zeeshan Ali (Khattak)
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau wrote: > On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: >> +{ >> +    g_debug("Init GVirConfigCapabilitiesCPUFeature=%p", conn); >> + >> +    conn->priv = GVIR_CONFIG_CAPABILITIES_CPU_FEATURE_GET_PRIVATE(conn); >> +} >> +

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-02 Thread Daniel P. Berrange
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > diff --git a/libvirt-gconfig/libvirt-gconfig.sym > b/libvirt-gconfig/libvirt-gconfig.sym > index ffeb16b..b1df17b 100644 > --- a/libvirt-gconfig/libvirt-gconfig.sym > +++ b/libvirt-gconfig/lib

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-02 Thread Christophe Fergeau
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Not quite complete but its a good start. > --- > libvirt-gconfig/Makefile.am| 11 ++- > ...virt-gconfig-capabilities-cpu-feature-private.h | 39 ++ > .../lib

[libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-01 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" Not quite complete but its a good start. --- libvirt-gconfig/Makefile.am| 11 ++- ...virt-gconfig-capabilities-cpu-feature-private.h | 39 ++ .../libvirt-gconfig-capabilities-cpu-feature.c | 77 .../libvirt-gconfig-