Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

2017-10-03 Thread Andrea Bolognani
On Tue, 2017-10-03 at 09:59 +0100, Daniel P. Berrange wrote: > > I'm not adamant on keeping this around, as it was mainly a tool > > for me to use during development, but I figure it might come in > > handy later on when some project picks up new (optional) build > > dependencies or we need to add

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

2017-10-03 Thread Daniel P. Berrange
On Tue, Oct 03, 2017 at 09:07:15AM +0200, Andrea Bolognani wrote: > On Mon, 2017-10-02 at 17:04 +0100, Daniel P. Berrange wrote: > > > +- name: '{{ project }}: Run sanity checks' > > > + command: '{{ make }} -j{{ smp }} syntax-check' > > > + args: > > > +chdir: '{{ project }}' > > > + when:

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

2017-10-03 Thread Andrea Bolognani
On Mon, 2017-10-02 at 17:04 +0100, Daniel P. Berrange wrote: > > +- name: '{{ project }}: Run sanity checks' > > + command: '{{ make }} -j{{ smp }} syntax-check' > > + args: > > +chdir: '{{ project }}' > > + when: > > +- project == 'libosinfo' > > This looks like its duplicating the

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

2017-10-02 Thread Daniel P. Berrange
On Mon, Oct 02, 2017 at 05:10:41PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ansible/host_vars/libvirt-centos-7/main.yml | 1 + > ansible/host_vars/libvirt-debian-8/main.yml | 1 + > ansible/host_vars/libvirt-debian-9/main.yml

[libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

2017-10-02 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- ansible/host_vars/libvirt-centos-7/main.yml | 1 + ansible/host_vars/libvirt-debian-8/main.yml | 1 + ansible/host_vars/libvirt-debian-9/main.yml | 1 + ansible/host_vars/libvirt-fedora-25/main.yml | 1 +