Re: [libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

2018-04-15 Thread Andrea Bolognani
On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > We require QEMU >= 0.15.0, assume every QEMU supports it. s/0.15.0/1.5.0/ Unless the usable monitor was introduced in 0.15.0, in which case your version is more precise. > Sadly that does not let us trivially drop qemuMonitor's >

Re: [libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

2018-04-12 Thread Ján Tomko
On Thu, Apr 12, 2018 at 09:45:48AM +0200, Andrea Bolognani wrote: On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: We require QEMU >= 0.15.0, assume every QEMU supports it. s/0.15.0/1.5.0/ Unless the usable monitor was introduced in 0.15.0, in which case your version is more precise.

[libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

2018-04-09 Thread Ján Tomko
We require QEMU >= 0.15.0, assume every QEMU supports it. Sadly that does not let us trivially drop qemuMonitor's priv->monJSON bool, because of qemuDomainQemuAttach. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 -