Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-15 Thread Martin Kletzander
On Wed, Feb 15, 2017 at 01:40:30PM +0800, Eli Qiao wrote: On Wednesday, 15 February 2017 at 1:14 AM, Marcelo Tosatti wrote: On Tue, Feb 14, 2017 at 09:37:02AM +0100, Martin Kletzander wrote: > On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: > > On Mon, Feb 13, 2017 at

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-14 Thread Eli Qiao
-- Eli Qiao Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 15 February 2017 at 1:14 AM, Marcelo Tosatti wrote: > On Tue, Feb 14, 2017 at 09:37:02AM +0100, Martin Kletzander wrote: > > On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: > > > On Mon, Feb

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-14 Thread Marcelo Tosatti
On Tue, Feb 14, 2017 at 09:37:02AM +0100, Martin Kletzander wrote: > On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: > >On Mon, Feb 13, 2017 at 03:42:04PM +0800, Eli Qiao wrote: > >>> > L3data:0=0xff00;... > >>> > L3code:0=0xff00;... > >>> > > >>> > * Would you please help to test

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-14 Thread Marcelo Tosatti
On Tue, Feb 14, 2017 at 04:59:52PM +0800, Eli Qiao wrote: > > > -- > Eli Qiao > Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > > > On Tuesday, 14 February 2017 at 4:37 PM, Martin Kletzander wrote: > > > On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: > > > On Mon,

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-14 Thread Eli Qiao
-- Eli Qiao Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Tuesday, 14 February 2017 at 4:37 PM, Martin Kletzander wrote: > On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: > > On Mon, Feb 13, 2017 at 03:42:04PM +0800, Eli Qiao wrote: > > > > > L3data:0=0xff00;...

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-14 Thread Martin Kletzander
On Mon, Feb 13, 2017 at 04:09:13PM -0200, Marcelo Tosatti wrote: On Mon, Feb 13, 2017 at 03:42:04PM +0800, Eli Qiao wrote: > > L3data:0=0xff00;... > > L3code:0=0xff00;... > > > > * Would you please help to test if the functions work. > > Setting up CDP machine. > > Unrelated: > > Found a bug: >

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-13 Thread Marcelo Tosatti
On Mon, Feb 13, 2017 at 03:42:04PM +0800, Eli Qiao wrote: > > > L3data:0=0xff00;... > > > L3code:0=0xff00;... > > > > > > * Would you please help to test if the functions work. > > > > Setting up CDP machine. > > > > Unrelated: > > > > Found a bug: > > > > The code should scan for all

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-12 Thread Eli Qiao
-- Eli Qiao Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Friday, 10 February 2017 at 10:19 PM, Marcelo Tosatti wrote: > On Fri, Feb 10, 2017 at 02:42:04PM +0800, Eli Qiao wrote: > > Addressed comment from v3 -> v4: > > > > Daniel & Marcelo: > > * Added concurrence support > >

Re: [libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-10 Thread Marcelo Tosatti
On Fri, Feb 10, 2017 at 02:42:04PM +0800, Eli Qiao wrote: > Addressed comment from v3 -> v4: > > Daniel & Marcelo: >* Added concurrence support > > Addressed comment from v2 -> v3: > > Daniel: > * Fixed coding style, passed `make check` and `make syntax-check` > > *

[libvirt] [v4 0/9] Support cache tune in libvirt

2017-02-09 Thread Eli Qiao
Addressed comment from v3 -> v4: Daniel & Marcelo: * Added concurrence support Addressed comment from v2 -> v3: Daniel: * Fixed coding style, passed `make check` and `make syntax-check` * Variables renaming and move from header file to c file. * For locking/mutex