Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-13 Thread Erik Skultety
On Tue, Jun 13, 2017 at 03:06:14PM +0200, Michal Privoznik wrote: > On 06/13/2017 03:05 PM, Erik Skultety wrote: > > On Tue, Jun 13, 2017 at 01:55:24PM +0200, Michal Privoznik wrote: > >> On 06/13/2017 11:02 AM, Erik Skultety wrote: > >>> On Mon, Jun 12, 2017 at 02:02:20AM -0400, Yi Wang wrote: >

Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-13 Thread Michal Privoznik
On 06/13/2017 03:05 PM, Erik Skultety wrote: > On Tue, Jun 13, 2017 at 01:55:24PM +0200, Michal Privoznik wrote: >> On 06/13/2017 11:02 AM, Erik Skultety wrote: >>> On Mon, Jun 12, 2017 at 02:02:20AM -0400, Yi Wang wrote: The @rundir is allocated in virGetUserRuntimeDirectory, may lost

Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-13 Thread Erik Skultety
On Tue, Jun 13, 2017 at 01:55:24PM +0200, Michal Privoznik wrote: > On 06/13/2017 11:02 AM, Erik Skultety wrote: > > On Mon, Jun 12, 2017 at 02:02:20AM -0400, Yi Wang wrote: > >> The @rundir is allocated in virGetUserRuntimeDirectory, may lost > >> when virFileMakePath failed. > > > > ACK. I

Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-13 Thread Michal Privoznik
On 06/13/2017 11:02 AM, Erik Skultety wrote: > On Mon, Jun 12, 2017 at 02:02:20AM -0400, Yi Wang wrote: >> The @rundir is allocated in virGetUserRuntimeDirectory, may lost >> when virFileMakePath failed. > > ACK. I slightly reworded the commit message and pushed. > Funny, I have a similar patch

Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-13 Thread Erik Skultety
On Mon, Jun 12, 2017 at 02:02:20AM -0400, Yi Wang wrote: > The @rundir is allocated in virGetUserRuntimeDirectory, may lost > when virFileMakePath failed. ACK. I slightly reworded the commit message and pushed. Thanks, Erik -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths

2017-06-11 Thread Yi Wang
The @rundir is allocated in virGetUserRuntimeDirectory, may lost when virFileMakePath failed. Signed-off-by: Xi Xu --- daemon/libvirtd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index bac4bc1..d17a694 100644 ---

Re: [libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths and qemuMonitorJSONAttachCharDevCommand

2017-05-28 Thread Peter Krempa
On Fri, May 26, 2017 at 21:10:50 -0400, Yi Wang wrote: > From: Xi Xu > > The @rundir is allocated in virGetUserRuntimeDirectory, may lost > when virFileMakePath failed. > > The tlsalias allocated in qemuAliasTLSObjFromSrcAlias may lost > when append string to json. Those are

[libvirt] [PATCH] fix memory leak in daemonUnixSocketPaths and qemuMonitorJSONAttachCharDevCommand

2017-05-26 Thread Yi Wang
From: Xi Xu The @rundir is allocated in virGetUserRuntimeDirectory, may lost when virFileMakePath failed. The tlsalias allocated in qemuAliasTLSObjFromSrcAlias may lost when append string to json. --- daemon/libvirtd.c| 1 + src/qemu/qemu_monitor_json.c | 2 ++ 2