Re: [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-14 Thread Stefan Hajnoczi
On Wed, Sep 13, 2017 at 05:28:56PM +0200, Michal Privoznik wrote: > On 09/13/2017 03:54 PM, Stefan Hajnoczi wrote: > > 2. Only allow NVDIMM hotplug if the domain was started with -M > >nvdimm=on. > > > > I think QEMU will not add -M nvdimm=on to the "pc" machine type by > > default since it

Re: [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-14 Thread Michal Privoznik
On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > On 09/13/17 17:28 +0200, Michal Privoznik wrote: >> >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on >> and guest migrated happily. So looks like guest ABI is stable (or at >> least stable enough not to crash). But since

Re: [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-13 Thread Haozhong Zhang
On 09/13/17 17:28 +0200, Michal Privoznik wrote: > > BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > and guest migrated happily. So looks like guest ABI is stable (or at > least stable enough not to crash). But since ACPI table is changed I > doubt that. One example

Re: [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-13 Thread Michal Privoznik
On 09/13/2017 03:54 PM, Stefan Hajnoczi wrote: > Hi Michal, > You asked how NVDIMM hotplug should work if the domain was launched > without -M nvdimm=on. I'm not very familiar with ACPI so this may be > incorrect. > > Hotplug relies on the presence of ACPI tables (SSDT Device=NVDR >

[libvirt] QEMU -M nvdimm=on and hotplug

2017-09-13 Thread Stefan Hajnoczi
Hi Michal, You asked how NVDIMM hotplug should work if the domain was launched without -M nvdimm=on. I'm not very familiar with ACPI so this may be incorrect. Hotplug relies on the presence of ACPI tables (SSDT Device=NVDR _HID=ACPI0012) added by -M nvdimm=on. The ACPI tables contain the