Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-10-09 Thread Bruno Haible
Daniel P. Berrange wrote: > Tested-by: Daniel P. Berrange > > > Confirmed it fixes the failure on Fedora 28, and does not cause a regression > on Fedora 26 with older glibc. Thanks. Pushing it: 2017-10-09 Bruno Haible getopt-posix: Fix build

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-10-09 Thread Daniel P. Berrange
On Fri, Oct 06, 2017 at 07:59:13PM +0200, Bruno Haible wrote: > Daniel P. Berrange wrote: > > From my own F28 rawhide install with glibc-2.26.90-16.fc28.x86_64 > > > > > > > > 1) The output of > > > $ nm test-getopt-posix | grep getopt > > > > $ nm test-getopt-posix | grep getopt > >

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-10-06 Thread Bruno Haible
Daniel P. Berrange wrote: > From my own F28 rawhide install with glibc-2.26.90-16.fc28.x86_64 > > > > > 1) The output of > > $ nm test-getopt-posix | grep getopt > > $ nm test-getopt-posix | grep getopt > U getopt@@GLIBC_2.2.5 > 00400ab0 t getopt_loop.constprop.0

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-29 Thread Bruno Haible
Hi, Christian Ehrhardt wrote: > > Fedora 26 only has glibc 2.25 - you need to have Fedora rawhide to get > > the broken behaviour, as that has glibc 2.26.90 > As Daniel said at least glibc 2.26 as in Fedora rawhide or Ubuntu Artful. This tip is not helpful: I spent two hours trying Fedora

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-29 Thread Paul Eggert
On 09/29/2017 05:02 AM, Christian Ehrhardt wrote: Here [1] a log of your commands on such a system showing the issue. Thanks, but I still don't understand what the bug is. With those commands, the test programs use Gnulib-supplied getopt, not the glibc getopt. So why would any change in

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-29 Thread Christian Ehrhardt
On Fri, Sep 29, 2017 at 10:45 AM, Daniel P. Berrange wrote: > On Thu, Sep 28, 2017 at 04:41:37PM -0700, Paul Eggert wrote: > > That patch essentially negates the point of the test, which is that > getopt > > should be visible from unistd.h. I'd rather fix the problem than

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-29 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 04:41:37PM -0700, Paul Eggert wrote: > That patch essentially negates the point of the test, which is that getopt > should be visible from unistd.h. I'd rather fix the problem than nuke the > test. > > Could you explain what the Gnulib problem is here? I can't really see

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-28 Thread Paul Eggert
That patch essentially negates the point of the test, which is that getopt should be visible from unistd.h. I'd rather fix the problem than nuke the test. Could you explain what the Gnulib problem is here? I can't really see it in your email. A self-contained example would help. For what

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 11:36:20PM +0200, Christian Ehrhardt wrote: > Hi, > there seems to be an incompatibility to the last glibc due to [1]. > > Eventually this breaks gnulib unittests (and maybe more). [snip] We should have detected this a while ago sinc Fedora rawhide has 2.26, in fact it

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-28 Thread Christian Ehrhardt
On Thu, Sep 28, 2017 at 2:05 PM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Sep 28, 2017 at 12:25 AM, Eric Blake wrote: > >> [adding gnulib] >> > > [...] > >> > then libvirt needs to pick up the >> updated gnulib. > > > I copied in current

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-28 Thread Christian Ehrhardt
On Thu, Sep 28, 2017 at 12:25 AM, Eric Blake wrote: > [adding gnulib] > > On 09/27/2017 04:36 PM, Christian Ehrhardt wrote: > > Hi, > > there seems to be an incompatibility to the last glibc due to [1]. > > Gnulib needs to be updated to track the glibc changes (it looks like >

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-27 Thread Eric Blake
[adding gnulib] On 09/27/2017 04:36 PM, Christian Ehrhardt wrote: > Hi, > there seems to be an incompatibility to the last glibc due to [1]. Gnulib needs to be updated to track the glibc changes (it looks like that is actually under way already), then libvirt needs to pick up the updated gnulib.

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-27 Thread Christian Ehrhardt
I did an in-place replacement of gnulib to the latest from gnulib upstream but the issue stays. So for the time being i'd assume it is not yet solved there. On Wed, Sep 27, 2017 at 11:36 PM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > Hi, > there seems to be an

[libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-09-27 Thread Christian Ehrhardt
Hi, there seems to be an incompatibility to the last glibc due to [1]. Eventually this breaks gnulib unittests (and maybe more). Debugging went from an assert, to bidngin different symbols, to changed function names to different header resolution. Because it expects it to behave "posixly" but