re-sending, thank you Erik!
On Wed, Apr 15, 2015 at 9:48 PM, Eric Blake ebl...@redhat.com wrote:
On 04/15/2015 01:38 PM, Laszlo Hornyak wrote:
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14
On 04/15/2015 01:38 PM, Laszlo Hornyak wrote:
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14 ++
1 file changed, 14 insertions(+)
I'm not qualified to review the patch proper; but
On Sat, Nov 01, 2014 at 10:40:06PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:19:23 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote:
Hi.
Here are a few patches that piled up in my local branch. Some of them
I already
At Fri, 21 Feb 2014 11:19:23 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote:
Hi.
Here are a few patches that piled up in my local branch. Some of them
I already submitted to this list, but there has been no reponse to
them.
Included
At Wed, 26 Mar 2014 03:29:34 +,
Chris Ellis wrote:
Update the pom to set the Java source level. This enables Eclipse
to correctly configure itself.
So, you let ant generate the pom.xml and use that with Eclipse, right?
Also include plugins to publish the source and javadocs vai Maven.
At Fri, 21 Feb 2014 11:03:49 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:47PM +0100, Claudio Bley wrote:
Add initEventLoop(), processEvent(), runEventLoop() and stopEventLoop()
static methods to the Library class.
Signed-off-by: Claudio Bley cb...@av-test.de
---
On Wed, Mar 26, 2014 at 7:52 AM, Claudio Bley cb...@av-test.de wrote:
At Wed, 26 Mar 2014 03:29:34 +,
Chris Ellis wrote:
Update the pom to set the Java source level. This enables Eclipse
to correctly configure itself.
So, you let ant generate the pom.xml and use that with Eclipse,
On Wed, Mar 26, 2014 at 4:32 AM, Eric Blake ebl...@redhat.com wrote:
On 03/25/2014 10:19 PM, Eric Blake wrote:
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also
At Fri, 21 Feb 2014 10:33:44 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote:
java/org/libvirt/Error.java:217:
The static method wrap(int) from the type Error.ErrorDomain should be
accessed in a static way
Signed-off-by: Claudio Bley
At Fri, 21 Feb 2014 10:32:08 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote:
Eclipse generates this kind of warning:
org/libvirt/jna/virConnectCredential.java:20:
List is a raw type. References to generic type ListE should be
At Fri, 21 Feb 2014 10:34:05 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:11PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Error.java |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
ACK
At Fri, 21 Feb 2014 10:34:24 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:12PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
At Fri, 21 Feb 2014 10:34:52 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java |2 ++
1 file changed, 2 insertions(+)
ACK
Thanks,
At Fri, 21 Feb 2014 10:35:17 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Error.java | 397
++
1 file changed, 262
At Fri, 21 Feb 2014 10:35:42 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
.gitignore |2 ++
1 file changed, 2 insertions(+)
ACK. Counts as a trivial patch that can be pushed
At Fri, 21 Feb 2014 10:36:33 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:17PM +0100, Claudio Bley wrote:
On Windows, the libvirt DLL is called libvirt-0.dll. Trying to load
the virt library hence fails to find the file. Branch on the platform
and load virt-0 if we're
At Fri, 21 Feb 2014 10:40:46 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:20PM +0100, Claudio Bley wrote:
JUnit is used for quite some time now, which supercedes the tests
defined in the old test class.
Signed-off-by: Claudio Bley cb...@av-test.de
---
At Fri, 21 Feb 2014 14:42:26 +0100,
Claudio Bley wrote:
At Fri, 21 Feb 2014 10:37:36 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:18PM +0100, Claudio Bley wrote:
Libvirt function parameters having type (pointer to) size_t were
wrapped via JNA using int, long or
At Fri, 21 Feb 2014 10:41:35 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:21PM +0100, Claudio Bley wrote:
The libvirt function virNodeDeviceListCaps might return fewer elements
than requested. Take this into account and properly decode the UTF-8
strings returned.
At Fri, 21 Feb 2014 10:42:22 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:22PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java | 14 ++
1 file changed, 14 insertions(+)
ACK
At Fri, 21 Feb 2014 10:44:42 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:25PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also update erroneous javadoc comments stating that methods would return a
value
At Fri, 21 Feb 2014 10:45:01 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:26PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:43:15 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:23PM +0100, Claudio Bley wrote:
Almost every class contains a processError() method with an identical
definition, just forwarding the call to ErrorHandler.processError(Libvirt).
This function is
At Fri, 21 Feb 2014 10:43:43 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:24PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Signed-off-by: Claudio Bley cb...@av-test.de
---
At Fri, 21 Feb 2014 10:46:19 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:29PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:48:44 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:30PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:45:22 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:27PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:49:33 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:32PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:49:52 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:33PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:50:57 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:35PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Library.java |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK
At Fri, 21 Feb 2014 10:50:22 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:34PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..) and remove calls to the deprecated
ErrorHandler.processError(Libvirt) method.
Also
At Fri, 21 Feb 2014 10:45:55 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:28PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in
At Fri, 21 Feb 2014 10:51:17 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:36PM +0100, Claudio Bley wrote:
It was deprecated and is no longer used.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/ErrorHandler.java | 12
1
At Fri, 21 Feb 2014 10:49:15 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:31PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Adjust the doc comment for storageVolLookupByName to indicate that
it might
At Fri, 21 Feb 2014 10:57:10 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:38PM +0100, Claudio Bley wrote:
The getSchedulerType method returns a String (the name of the
scheduler), not a String array containing a single element.
It's OK to just pass null for the second
eAt Fri, 21 Feb 2014 10:57:44 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:39PM +0100, Claudio Bley wrote:
We need to free the char* entries of the result array returned ourselves.
Signed-off-by: Claudio Bley cb...@av-test.de
---
At Fri, 21 Feb 2014 10:58:35 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:40PM +0100, Claudio Bley wrote:
We need to free the char* entries of the result array returned
ourselves.
Signed-off-by: Claudio Bley cb...@av-test.de
---
At Fri, 21 Feb 2014 10:36:10 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:16PM +0100, Claudio Bley wrote:
Specify a version range for the net.java.dev.jna / jna artifact
in order to accept any version we tested the libvirt Java bindings
against.
Signed-off-by:
At Fri, 21 Feb 2014 10:59:25 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:42PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/StorageVol.java | 10 +-
src/main/java/org/libvirt/jna/Libvirt.java |
At Fri, 21 Feb 2014 11:21:17 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote:
Hi.
Here are a few patches that piled up in my local branch. Some of them
I already submitted to this list, but there has been no reponse to
them.
Included
At Fri, 21 Feb 2014 10:59:02 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:41PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/DomainSnapshot.java | 10 +-
src/main/java/org/libvirt/jna/Libvirt.java
At Fri, 21 Feb 2014 10:59:44 +,
Daniel P. Berrange wrote:
On Thu, Feb 13, 2014 at 04:22:43PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/StorageVol.java |8 +++-
src/main/java/org/libvirt/jna/Libvirt.java |2
Hi.
This is a small patch set to fix a few issues I've discovered while testing
Claudio's patch set.
The first patch is trivial, it adds the ConnectionCloseListener interface and
corresponding
enum, which were missing.
The second patch ensures that the JNA callbacks cannot be garbage
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This
allows Maven (and IDE integration) to automatically
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This
Update the pom to set the Java source level. This enables Eclipse
to correctly configure itself.
Also include plugins to publish the source and javadocs vai Maven.
Update .gitignore to exclude a local pom.
---
.gitignore | 1 +
pom.xml.in | 41 +
2
On 03/25/2014 10:19 PM, Eric Blake wrote:
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the
[FTR, I've noticed the same thing when I started to use the Java
bindings. Back then, this made me wonder whether the bindings are
actually used by someone, because the constants are rather useless
without being public and nobody objected...]
At Fri, 21 Mar 2014 14:05:26 -0600,
Yoshikazu
Hi,
I'd like to submit a small patch to libvirt-java.
This patch make Flags used to manipulate Domain accessible from
outside of the package
I'm new to libvirt-java development process, please let me know if I
miss something.
Thanks!
Yoshikazu Nojima m...@ynojima.net
From
At Tue, 11 Mar 2014 11:18:57 +0100,
Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java | 39 +
src/main/java/org/libvirt/Domain.java | 52
++-
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java | 39 +
src/main/java/org/libvirt/Domain.java | 52 ++-
src/test/java/org/libvirt/TestJavaBindings.java |4 ++
3 files changed, 94 insertions(+),
On Tue, Mar 04, 2014 at 08:31:04AM +0100, Claudio Bley wrote:
At Mon, 3 Mar 2014 15:58:25 +,
Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the
At Mon, 03 Mar 2014 13:06:50 -0700,
Eric Blake wrote:
[1 text/plain; UTF-8 (quoted-printable)]
On 02/13/2014 08:22 AM, Claudio Bley wrote:
Note: these are only used internally.
Signed-off-by: Claudio Bley cb...@av-test.de
---
+static final int CONTROL_ERROR = 7;
+
At Thu, 27 Feb 2014 03:47:31 +,
Chris Ellis wrote:
Hi all
I'm new to this list, I've been making use of the Libvirt Java bindings
recently. I wanted to make use of domain events yesterday
so my application can be alerted when the state of a domain changes etc.
However I quickly
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the virEventUpdateTimeout method
OK, but why should I add it? It's useless (for the user) and unused by
the wrapping code. I want to keep the JNA library definition clean --
e.g. in a later patch I remove all
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the virEventUpdateTimeout method
OK, but why should I add it? It's useless (for the user) and unused by
the wrapping code. I want to keep the
On 03/03/2014 08:58 AM, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the virEventUpdateTimeout method
OK, but why should I add it? It's useless (for the user) and
On 02/13/2014 08:22 AM, Claudio Bley wrote:
Note: these are only used internally.
Signed-off-by: Claudio Bley cb...@av-test.de
---
+static final int CONTROL_ERROR = 7;
+static final int BLOCK_JOB = 8;
+static final int DISK_CHANGE = 9;
+static final int
Hi Claudio
On Mon, Mar 3, 2014 at 3:00 PM, Claudio Bley cb...@av-test.de wrote:
At Thu, 27 Feb 2014 03:47:31 +,
Chris Ellis wrote:
Hi all
I'm new to this list, I've been making use of the Libvirt Java bindings
recently. I wanted to make use of domain events yesterday
so my
Eric Blake wrote:
On 03/03/2014 08:58 AM, Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the virEventUpdateTimeout method
OK, but why
At Mon, 3 Mar 2014 15:58:25 +,
Daniel P. Berrange wrote:
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +,
Daniel P. Berrange wrote:
ACK, if you also add the virEventUpdateTimeout method
OK, but why should I add it? It's
On 02/26/2014 08:47 PM, Chris Ellis wrote:
Hi all
I'm new to this list, I've been making use of the Libvirt Java bindings
recently. I wanted to make use of domain events yesterday
so my application can be alerted when the state of a domain changes etc.
Sideline observations (I'm not a user
On Thu, Feb 27, 2014 at 03:47:31AM +, Chris Ellis wrote:
Hi all
I'm new to this list, I've been making use of the Libvirt Java bindings
recently. I wanted to make use of domain events yesterday
so my application can be alerted when the state of a domain changes etc.
[snip]
I've put
Hi all
I'm new to this list, I've been making use of the Libvirt Java bindings
recently. I wanted to make use of domain events yesterday
so my application can be alerted when the state of a domain changes etc.
However I quickly discovered that domain events are completely broken in
the current
On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote:
Eclipse generates this kind of warning:
org/libvirt/jna/virConnectCredential.java:20:
List is a raw type. References to generic type ListE should be parameterized
Signed-off-by: Claudio Bley cb...@av-test.de
---
On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java |2 ++
1 file changed, 2 insertions(+)
ACK
Daniel
--
|: http://berrange.com -o-
On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Error.java | 397
++
1 file changed, 262 insertions(+), 135 deletions(-)
ACK
Daniel
--
|: http://berrange.com
On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote:
java/org/libvirt/Error.java:217:
The static method wrap(int) from the type Error.ErrorDomain should be
accessed in a static way
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Error.java |6 +++---
On Thu, Feb 13, 2014 at 04:22:12PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Daniel
--
|: http://berrange.com -o-
On Thu, Feb 13, 2014 at 04:22:16PM +0100, Claudio Bley wrote:
Specify a version range for the net.java.dev.jna / jna artifact
in order to accept any version we tested the libvirt Java bindings
against.
Signed-off-by: Claudio Bley cb...@av-test.de
---
As discussed previously[1], with a
On Thu, Feb 13, 2014 at 04:22:17PM +0100, Claudio Bley wrote:
On Windows, the libvirt DLL is called libvirt-0.dll. Trying to load
the virt library hence fails to find the file. Branch on the platform
and load virt-0 if we're running on this OS, use virt otherwise.
Signed-off-by: Claudio Bley
On Thu, Feb 13, 2014 at 04:22:18PM +0100, Claudio Bley wrote:
Libvirt function parameters having type (pointer to) size_t were
wrapped via JNA using int, long or even NativeLong. Alas, none of
these is actually correct as the size of size_t may be the same as the
size of either (unsigned) int,
On Thu, Feb 13, 2014 at 04:22:21PM +0100, Claudio Bley wrote:
The libvirt function virNodeDeviceListCaps might return fewer elements
than requested. Take this into account and properly decode the UTF-8
strings returned.
Additionally, the given strings are freed before returning the
On Thu, Feb 13, 2014 at 04:22:20PM +0100, Claudio Bley wrote:
JUnit is used for quite some time now, which supercedes the tests
defined in the old test class.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/test.java | 280
---
On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
.gitignore |2 ++
1 file changed, 2 insertions(+)
ACK. Counts as a trivial patch that can be pushed without asking.
Daniel
--
|: http://berrange.com -o-
On Thu, Feb 13, 2014 at 04:22:22PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/test/java/org/libvirt/TestJavaBindings.java | 14 ++
1 file changed, 14 insertions(+)
ACK
Daniel
--
|: http://berrange.com -o-
On Thu, Feb 13, 2014 at 04:22:24PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Device.java | 49
++---
1 file changed, 14
On Thu, Feb 13, 2014 at 04:22:23PM +0100, Claudio Bley wrote:
Almost every class contains a processError() method with an identical
definition, just forwarding the call to ErrorHandler.processError(Libvirt).
This function is always called after a libvirt function call (as per its
javadoc
On Thu, Feb 13, 2014 at 04:22:25PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
Also update erroneous javadoc comments stating that methods would return a
value in case an error occurs. In case of a libvirt error, a
On Thu, Feb 13, 2014 at 04:22:27PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in case an error occurs.
Signed-off-by: Claudio Bley cb...@av-test.de
On Thu, Feb 13, 2014 at 04:22:28PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in case an error occurs.
Signed-off-by: Claudio Bley cb...@av-test.de
On Thu, Feb 13, 2014 at 04:22:26PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in case an error happens.
Signed-off-by: Claudio Bley cb...@av-test.de
On Thu, Feb 13, 2014 at 04:22:35PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Library.java |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o-
On Thu, Feb 13, 2014 at 04:22:32PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in case an error occurs.
Signed-off-by: Claudio Bley cb...@av-test.de
On Thu, Feb 13, 2014 at 04:22:19PM +0100, Claudio Bley wrote:
When JNA is linked to a different runtime library than libvirt, using
JNA's Native.free will probably lead to crashes as witnessed on
Windows:
# A fatal error has been detected by the Java Runtime Environment:
#
#
On Thu, Feb 13, 2014 at 04:22:36PM +0100, Claudio Bley wrote:
It was deprecated and is no longer used.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/ErrorHandler.java | 12
1 file changed, 12 deletions(-)
ACK
Regards,
Daniel
--
|:
On Thu, Feb 13, 2014 at 04:22:31PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Adjust the doc comment for storageVolLookupByName to indicate that
it might return null.
Also correct wrong javadoc comments stating that methods
On Thu, Feb 13, 2014 at 04:22:38PM +0100, Claudio Bley wrote:
The getSchedulerType method returns a String (the name of the
scheduler), not a String array containing a single element.
It's OK to just pass null for the second argument to
virDomainGetSchedulerType.
Ensure to free the
On Thu, Feb 13, 2014 at 04:22:37PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java | 35 +
src/main/java/org/libvirt/Domain.java | 48
++-
On Thu, Feb 13, 2014 at 04:22:33PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..).
Also correct wrong javadoc comments stating that methods would return
a value in case an error occurs.
Signed-off-by: Claudio Bley cb...@av-test.de
On Thu, Feb 13, 2014 at 04:22:40PM +0100, Claudio Bley wrote:
We need to free the char* entries of the result array returned
ourselves.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/StoragePool.java | 13 ++---
On Thu, Feb 13, 2014 at 04:22:43PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/StorageVol.java |8 +++-
src/main/java/org/libvirt/jna/Libvirt.java |2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
ACK
Regards,
On Thu, Feb 13, 2014 at 04:22:34PM +0100, Claudio Bley wrote:
Wrap any fallible libvirt function in a call to
ErrorHandler.processError(..) and remove calls to the deprecated
ErrorHandler.processError(Libvirt) method.
Also correct wrong javadoc comments stating that methods would return
a
On Thu, Feb 13, 2014 at 04:22:39PM +0100, Claudio Bley wrote:
We need to free the char* entries of the result array returned ourselves.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Domain.java | 14 +++---
On Thu, Feb 13, 2014 at 04:22:46PM +0100, Claudio Bley wrote:
This wraps the virConnectSetKeepAlive libvirt function available since
version 0.9.8.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java | 34
On Thu, Feb 13, 2014 at 04:22:48PM +0100, Claudio Bley wrote:
Note: these are only used internally.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java | 20
1 file changed, 20 insertions(+)
ACK
Regards,
Daniel
--
|:
On Thu, Feb 13, 2014 at 04:22:41PM +0100, Claudio Bley wrote:
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/DomainSnapshot.java | 10 +-
src/main/java/org/libvirt/jna/Libvirt.java|2 +-
2 files changed, 10 insertions(+), 2 deletions(-)
ACK
On Thu, Feb 13, 2014 at 04:22:44PM +0100, Claudio Bley wrote:
These functions are not (yet) exposed in the public org.libvirt
package but only used internally.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/jna/Libvirt.java | 11 +++
1 file changed,
On Thu, Feb 13, 2014 at 04:22:49PM +0100, Claudio Bley wrote:
Remove the public domainEventRegisterAny and domainEventDeregisterAny
methods. These methods basically were of no use since the only thing you
could register was a generic callback.
At runtime, you would have to provide a real
On Thu, Feb 13, 2014 at 04:22:51PM +0100, Claudio Bley wrote:
Add IOErrorActionListener and IOErrorAction enum which is handed to the
onIOError callback method when an IO error event occurs.
Signed-off-by: Claudio Bley cb...@av-test.de
---
src/main/java/org/libvirt/Connect.java
1 - 100 of 362 matches
Mail list logo
