Re: [libvirt] question on API spelling

2012-04-04 Thread Daniel Veillard
On Wed, Apr 04, 2012 at 09:06:27AM +0100, Daniel P. Berrange wrote: > On Tue, Apr 03, 2012 at 03:41:12PM -0600, Eric Blake wrote: > > On 04/03/2012 03:10 AM, Martin Kletzander wrote: > > > On 04/03/2012 01:05 AM, Eric Blake wrote: > > Do either of the Dan's have a strong opinion? And if the consen

Re: [libvirt] question on API spelling

2012-04-04 Thread Daniel P. Berrange
On Tue, Apr 03, 2012 at 03:41:12PM -0600, Eric Blake wrote: > On 04/03/2012 03:10 AM, Martin Kletzander wrote: > > On 04/03/2012 01:05 AM, Eric Blake wrote: > >> We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in > >> our public API: > >> > >> include/libvirt/libvirt.h.in:124:

Re: [libvirt] question on API spelling

2012-04-03 Thread Eric Blake
On 04/03/2012 03:10 AM, Martin Kletzander wrote: > On 04/03/2012 01:05 AM, Eric Blake wrote: >> We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in >> our public API: >> >> include/libvirt/libvirt.h.in:124: >> VIR_DOMAIN_RUNNING_MIGRATION_CANCELED = 6, /* returned from migrati

Re: [libvirt] question on API spelling

2012-04-03 Thread Martin Kletzander
On 04/03/2012 01:05 AM, Eric Blake wrote: > We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in > our public API: > > include/libvirt/libvirt.h.in:124: > VIR_DOMAIN_RUNNING_MIGRATION_CANCELED = 6, /* returned from migration */ > include/libvirt/libvirt.h.in:125:VIR_DOMAIN

[libvirt] question on API spelling

2012-04-02 Thread Eric Blake
We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in our public API: include/libvirt/libvirt.h.in:124: VIR_DOMAIN_RUNNING_MIGRATION_CANCELED = 6, /* returned from migration */ include/libvirt/libvirt.h.in:125:VIR_DOMAIN_RUNNING_SAVE_CANCELED = 7, /* returned from failed