Re: [libvirt PATCH] Revert "storage: volStorageBackendRBDRefreshVolInfo: refactor"

2021-01-09 Thread Laine Stump
On 1/8/21 8:00 AM, Ján Tomko wrote: Only set 'ret' once in any given execution path instead of mixing it with intermediate return values. This reverts commit 453bdebe5dcc3ec87d4db011e4f657fa24e42d94 I agree that we shouldn't be repeatedly setting ret as is done by the patch you're

[libvirt PATCH] Revert "storage: volStorageBackendRBDRefreshVolInfo: refactor"

2021-01-08 Thread Ján Tomko
Only set 'ret' once in any given execution path instead of mixing it with intermediate return values. This reverts commit 453bdebe5dcc3ec87d4db011e4f657fa24e42d94 Signed-off-by: Ján Tomko --- src/storage/storage_backend_rbd.c | 22 -- 1 file changed, 16 insertions(+), 6