Re: [libvirt PATCH] conf: allow for a partial match when searching for an

2021-03-23 Thread Laine Stump
On 3/23/21 8:44 AM, Michal Privoznik wrote: Honestly, this is not the most beautiful patch I've seen, but also I don't have any idea how to make it look better, I didn't like writing it either. Anyway, I like Dan's idea better - "that's not a regression, it's a bonus bugfix for a bug that

Re: [libvirt PATCH] conf: allow for a partial match when searching for an

2021-03-23 Thread Michal Privoznik
On 3/22/21 10:30 PM, Laine Stump wrote: Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias name of the being matched (in addition to already-existing match of MAC address and PCI/CCW address). This was done in response to https://bugzilla.redhat.com/1926190 which complained

Re: [libvirt PATCH] conf: allow for a partial match when searching for an

2021-03-23 Thread Laine Stump
On 3/23/21 5:37 AM, Daniel P. Berrangé wrote: On Mon, Mar 22, 2021 at 05:30:34PM -0400, Laine Stump wrote: Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias name of the being matched (in addition to already-existing match of MAC address and PCI/CCW address). This was done in

Re: [libvirt PATCH] conf: allow for a partial match when searching for an

2021-03-23 Thread Daniel P . Berrangé
On Mon, Mar 22, 2021 at 05:30:34PM -0400, Laine Stump wrote: > Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias > name of the being matched (in addition to already-existing > match of MAC address and PCI/CCW address). This was done in response > to

[libvirt PATCH] conf: allow for a partial match when searching for an

2021-03-22 Thread Laine Stump
Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias name of the being matched (in addition to already-existing match of MAC address and PCI/CCW address). This was done in response to https://bugzilla.redhat.com/1926190 which complained that it wasn't possible to unplug an