Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-22 Thread Michal Prívozník
On 8/19/22 11:57, Anthony PERARD wrote: > On Mon, Aug 01, 2022 at 10:23:48AM +0200, Michal Prívozník wrote: >> Ah, I couldn't find the commit in master, and it's simply because it's >> not there yet. It's in staging: >> >>

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-22 Thread Michal Prívozník
On 7/29/22 17:50, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Xen toolstack has gained basic Virtio support recently which becides > adding various virtio related stuff introduces new disk backend type > LIBXL_DISK_BACKEND_STANDALONE [1]. > > Unfortunately, this caused a

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-02 Thread Daniel P . Berrangé
On Tue, Aug 02, 2022 at 01:39:31PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Aug 01, 2022 at 10:36:07AM +0100, Daniel P. Berrangé wrote: > > Generally we want to see errors triggered from new enums arriving, > > as it can be a sign that libvirt code needs a semantic change in > > order to

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-02 Thread Marek Marczykowski-Górecki
On Mon, Aug 01, 2022 at 10:36:07AM +0100, Daniel P. Berrangé wrote: > Generally we want to see errors triggered from new enums arriving, > as it can be a sign that libvirt code needs a semantic change in > order to continue operating correctly. It isn't always correct > to assume that the

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-01 Thread Julien Grall
Hi Michal, On 01/08/2022 11:08, Michal Prívozník wrote: On 8/1/22 10:51, Julien Grall wrote: On 01/08/2022 09:23, Michal Prívozník wrote: On 7/29/22 17:50, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Xen toolstack has gained basic Virtio support recently which becides adding

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-01 Thread Michal Prívozník
On 8/1/22 10:51, Julien Grall wrote: > Hi Michal, > > On 01/08/2022 09:23, Michal Prívozník wrote: >> On 7/29/22 17:50, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> Xen toolstack has gained basic Virtio support recently which becides >>> adding various virtio related stuff

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-01 Thread Daniel P . Berrangé
On Mon, Aug 01, 2022 at 09:51:11AM +0100, Julien Grall wrote: > Hi Michal, > > On 01/08/2022 09:23, Michal Prívozník wrote: > > On 7/29/22 17:50, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > Xen toolstack has gained basic Virtio support recently which becides > > >

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-01 Thread Julien Grall
Hi Michal, On 01/08/2022 09:23, Michal Prívozník wrote: On 7/29/22 17:50, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Xen toolstack has gained basic Virtio support recently which becides adding various virtio related stuff introduces new disk backend type

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-01 Thread Michal Prívozník
On 7/29/22 17:50, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Xen toolstack has gained basic Virtio support recently which becides > adding various virtio related stuff introduces new disk backend type > LIBXL_DISK_BACKEND_STANDALONE [1]. > > Unfortunately, this caused a

[libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-07-29 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Xen toolstack has gained basic Virtio support recently which becides adding various virtio related stuff introduces new disk backend type LIBXL_DISK_BACKEND_STANDALONE [1]. Unfortunately, this caused a regression in libvirt build with Xen support enabled, reported by