Re: [libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-04-17 Thread Michal Prívozník
On 4/13/23 17:22, Ján Tomko wrote: > On a Thursday in 2023, Michal Prívozník wrote: >> On 3/22/23 11:07, Michal Prívozník wrote: >>> On 3/17/23 15:59, Peter Krempa wrote: On Thu, Mar 16, 2023 at 14:21:27 +0100, Ján Tomko wrote: > If we don't have dnsmasq, it's pointless to try to find

Re: [libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-04-13 Thread Ján Tomko
On a Thursday in 2023, Michal Prívozník wrote: On 3/22/23 11:07, Michal Prívozník wrote: On 3/17/23 15:59, Peter Krempa wrote: On Thu, Mar 16, 2023 at 14:21:27 +0100, Ján Tomko wrote: If we don't have dnsmasq, it's pointless to try to find its pidfile. Also, dnsmasqCapsGetBinaryPath would

Re: [libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-04-13 Thread Michal Prívozník
On 3/22/23 11:07, Michal Prívozník wrote: > On 3/17/23 15:59, Peter Krempa wrote: >> On Thu, Mar 16, 2023 at 14:21:27 +0100, Ján Tomko wrote: >>> If we don't have dnsmasq, it's pointless to try to find >>> its pidfile. >>> >>> Also, dnsmasqCapsGetBinaryPath would access a NULL pointer. >>> >>>

Re: [libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-03-22 Thread Michal Prívozník
On 3/17/23 15:59, Peter Krempa wrote: > On Thu, Mar 16, 2023 at 14:21:27 +0100, Ján Tomko wrote: >> If we don't have dnsmasq, it's pointless to try to find >> its pidfile. >> >> Also, dnsmasqCapsGetBinaryPath would access a NULL pointer. >> >> Fixes: 4b68c982e283471575bacbf87302495864da46fe >>

Re: [libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-03-17 Thread Peter Krempa
On Thu, Mar 16, 2023 at 14:21:27 +0100, Ján Tomko wrote: > If we don't have dnsmasq, it's pointless to try to find > its pidfile. > > Also, dnsmasqCapsGetBinaryPath would access a NULL pointer. > > Fixes: 4b68c982e283471575bacbf87302495864da46fe > Foxes:

[libvirt PATCH] network: do not assume dnsmasq in networkUpdateState

2023-03-17 Thread Ján Tomko
If we don't have dnsmasq, it's pointless to try to find its pidfile. Also, dnsmasqCapsGetBinaryPath would access a NULL pointer. Fixes: 4b68c982e283471575bacbf87302495864da46fe Foxes: https://gitlab.com/libvirt/libvirt/-/issues/456 Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 2