Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-23 Thread Laine Stump
On 10/23/20 1:28 AM, Peter Krempa wrote: On Thu, Oct 22, 2020 at 23:20:20 -0400, Laine Stump wrote: On 10/22/20 3:01 AM, Peter Krempa wrote: On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: On 10/21/20 5:50 PM, Jonathon Jongsma wrote: Coverity reported a potential resource leak.

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-22 Thread Peter Krempa
On Thu, Oct 22, 2020 at 14:08:51 -0500, Jonathon Jongsma wrote: > On Thu, 22 Oct 2020 09:01:13 +0200 > Peter Krempa wrote: > > > On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: > > > On 10/21/20 5:50 PM, Jonathon Jongsma wrote: > > > > Coverity reported a potential resource leak.

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-22 Thread Peter Krempa
On Thu, Oct 22, 2020 at 23:20:20 -0400, Laine Stump wrote: > On 10/22/20 3:01 AM, Peter Krempa wrote: > > On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: > > > On 10/21/20 5:50 PM, Jonathon Jongsma wrote: > > > > Coverity reported a potential resource leak. While it's probably not > > >

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-22 Thread Laine Stump
On 10/22/20 3:01 AM, Peter Krempa wrote: On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: On 10/21/20 5:50 PM, Jonathon Jongsma wrote: Coverity reported a potential resource leak. While it's probably not a real-world scenario, the code could technically jump to cleanup between the

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-22 Thread Jonathon Jongsma
On Thu, 22 Oct 2020 09:01:13 +0200 Peter Krempa wrote: > On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: > > On 10/21/20 5:50 PM, Jonathon Jongsma wrote: > > > Coverity reported a potential resource leak. While it's probably > > > not a real-world scenario, the code could

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-22 Thread Peter Krempa
On Wed, Oct 21, 2020 at 22:31:09 -0400, Laine Stump wrote: > On 10/21/20 5:50 PM, Jonathon Jongsma wrote: > > Coverity reported a potential resource leak. While it's probably not > > a real-world scenario, the code could technically jump to cleanup > > between the time that vdpafd is opened and

Re: [libvirt PATCH] qemu: fix potential resource leak

2020-10-21 Thread Laine Stump
On 10/21/20 5:50 PM, Jonathon Jongsma wrote: Coverity reported a potential resource leak. While it's probably not a real-world scenario, the code could technically jump to cleanup between the time that vdpafd is opened and when it is used. Ensure that it gets cleaned up in that case.

[libvirt PATCH] qemu: fix potential resource leak

2020-10-21 Thread Jonathon Jongsma
Coverity reported a potential resource leak. While it's probably not a real-world scenario, the code could technically jump to cleanup between the time that vdpafd is opened and when it is used. Ensure that it gets cleaned up in that case. Signed-off-by: Jonathon Jongsma ---