Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-19 Thread Neal Gompa
On Mon, Apr 19, 2021 at 11:10 AM Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 01:59:52PM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > > > On 4/19/21 2:24 PM, Neal Gompa wrote: > > > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-19 Thread Pavel Hrdina
On Mon, Apr 19, 2021 at 01:59:52PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > > On 4/19/21 2:24 PM, Neal Gompa wrote: > > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > > > > > > > > > > > > > I don't think this is a good

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > On 4/19/21 2:24 PM, Neal Gompa wrote: > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > > > > > > > > > I don't think this is a good "cleanup" to do. Having these checks is > > useful since without them, we'd blindly

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-19 Thread Michal Privoznik
On 4/19/21 2:24 PM, Neal Gompa wrote: On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: I don't think this is a good "cleanup" to do. Having these checks is useful since without them, we'd blindly build modules that possibly wouldn't work because we haven't verified that those

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-19 Thread Neal Gompa
On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > Recent attempt to add a lot of meson options to specify different > runtime paths motivated me enough to cleanup this from meson. > > Pavel Hrdina (17): > bridge_driver: fix comment about dnsmasqCaps > virdnsmasq: drop unused

[libvirt PATCH 00/17] drop meson checks for runtime binaries

2021-04-16 Thread Pavel Hrdina
Recent attempt to add a lot of meson options to specify different runtime paths motivated me enough to cleanup this from meson. Pavel Hrdina (17): bridge_driver: fix comment about dnsmasqCaps virdnsmasq: drop unused dnsmasqCapsNewFromFile function virdnsmasq: drop unused