On a Tuesday in 2020, Daniel P. Berrangé wrote:
On Tue, Jul 28, 2020 at 12:24:56PM +0200, Ján Tomko wrote:
For unattended bisects, it would be nice to return 125 which is the
magic value meaning 'skip' to 'git bisect run'.
I don't think its possible to force the ninja/meson exit status
upon
On Tue, Jul 28, 2020 at 12:15:25PM +0200, Peter Krempa wrote:
> On Tue, Jul 28, 2020 at 10:33:52 +0200, Pavel Hrdina wrote:
> > On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote:
>
> [...]
>
> >
> > Here I disagree, it also means that compilation should not fail. We do
> > comments
On Tue, Jul 28, 2020 at 10:46:07AM +0100, Daniel P. Berrangé wrote:
On Fri, Jul 17, 2020 at 07:27:50PM +0200, Martin Kletzander wrote:
On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at
On Tue, Jul 28, 2020 at 12:24:56PM +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Daniel P. Berrangé wrote:
> > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
> > > 3) Keep the patches as they are but error out in meson until the
> > >conversion is complete. The error
On a Tuesday in 2020, Daniel P. Berrangé wrote:
On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
3) Keep the patches as they are but error out in meson until the
conversion is complete. The error can be used to detect if git
bisect is withing the meson rewrite.
On Tue, Jul 28, 2020 at 12:08:17 +0200, Pavel Hrdina wrote:
> On Tue, Jul 28, 2020 at 10:58:03AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
[...]
> > - Meson build is forced to fail out of the box
> > - An option "force_incomplete_build"
On Tue, Jul 28, 2020 at 10:33:52 +0200, Pavel Hrdina wrote:
> On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote:
[...]
>
> Here I disagree, it also means that compilation should not fail. We do
> comments all the time to patch series that every single commit should
> compile
On Tue, Jul 28, 2020 at 10:58:03AM +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
> > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote:
> > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > > > On Thu, Jul 16, 2020 at
On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
> On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > > > On Thu, Jul 16, 2020 at
On Tue, 2020-07-28 at 10:00 +0200, Pavel Hrdina wrote:
> So based on all the comments we have these options for pushing this
> series:
>
> 1) Squash it into single commit.
>
> 2) Keep the patches as they are and running meson build & ninja will
>not fail.
>
> 3) Keep the
On Fri, Jul 17, 2020 at 07:27:50PM +0200, Martin Kletzander wrote:
> On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote:
> > > On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote:
> > > > On Thu, Jul
On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote:
> On Tue, Jul 28, 2020 at 10:00:20 +0200, Pavel Hrdina wrote:
> > On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote:
> > > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > > > On Thu, Jul 16, 2020 at
On Tue, Jul 28, 2020 at 10:00:20 +0200, Pavel Hrdina wrote:
> On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > > > On Thu, Jul 16, 2020 at
On Mon, Jul 27, 2020 at 06:11:11PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > > > Personally I'd really
On Mon, Jul 27, 2020 at 20:43:05 -0400, Neal Gompa wrote:
> On Mon, Jul 27, 2020 at 12:11 PM Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
[...]
> > I agree. It's definitely necessary that the build is complete at any
> > point in time.
> >
> > I'm
On Mon, Jul 27, 2020 at 12:11 PM Peter Krempa wrote:
>
> On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > > > Personally I'd really like to
On Fri, Jul 17, 2020 at 15:02:10 +0100, Daniel Berrange wrote:
> On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > > Personally I'd really like to avoid squashing them, because splitting
> > > up big patches
On Thu, Jul 23, 2020 at 11:15:49AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
>
> With the most recent version I've fetched from your repository I'm
> seeing the following test failure when building with 'gcc'. 'clang'
> builds fine.
Dan already
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
With the most recent version I've fetched from your repository I'm
seeing the following test failure when building with 'gcc'. 'clang'
builds fine.
The output from the failed tests:
11/154 check-virnetprotocolFAIL
On Fri, Jul 17, 2020 at 05:16:00PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > So I was finally able to produce the patches to port libvirt to Meson.
> > > Obviously,
On Fri, Jul 17, 2020 at 07:50:35PM +0200, Pavel Hrdina wrote:
> On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > So I was finally able to produce the patches to port libvirt to Meson.
> > > Obviously, it is
On Fri, Jul 17, 2020 at 07:00:07PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 17, 2020 at 07:50:35PM +0200, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > > So I was finally
On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be
On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote:
On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote:
On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > On Thu, Jul 16, 2020 at
On Fri, Jul 17, 2020 at 03:28:52PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be
On Fri, Jul 17, 2020 at 06:14:13PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 17, 2020 at 07:00:44PM +0200, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > > So I was finally
On Fri, Jul 17, 2020 at 07:00:44PM +0200, Pavel Hrdina wrote:
> On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > So I was finally able to produce the patches to port libvirt to Meson.
> > > Obviously, it is
On Fri, Jul 17, 2020 at 05:03:31PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 17, 2020 at 05:49:42PM +0200, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote:
>
> > > usr/share/doc/libvirt-docs/README is a symlink with meson ... the
> > > automake version
>
On Fri, Jul 17, 2020 at 03:24:38PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be
On Fri, Jul 17, 2020 at 03:51:21PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be
On Fri, Jul 17, 2020 at 05:49:42PM +0200, Pavel Hrdina wrote:
> On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote:
> > usr/share/doc/libvirt-docs/README is a symlink with meson ... the
> > automake version
> > doesn't differ. Is it even worth having them?
>
> The symlink is also in
On Fri, Jul 17, 2020 at 04:18:52PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> >
> > I've tried building RPMs both from the pre-patch tree state and after
> > your patchset. I've then
On Fri, Jul 17, 2020 at 04:53:28PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:37:45 +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote:
> > > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> > > > On Fri, Jul 17, 2020 at 16:04:16
On Fri, Jul 17, 2020 at 04:37:45PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > > > On Thu, Jul 16, 2020 at 11:53:56
On Fri, Jul 17, 2020 at 16:37:45 +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> > > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > > > On Thu, Jul 16, 2020 at 11:53:56
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> So I was finally able to produce the patches to port libvirt to Meson.
> Obviously, it is a lot of changes. It might look that some of the
> patches could be squashed together but I would rather have it as
> separated as possible to
On Fri, Jul 17, 2020 at 16:31:05 +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> > >
> > > I've tried building RPMs both
On Fri, Jul 17, 2020 at 04:31:05PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> > On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> > >
> > > I've tried building RPMs both
On Fri, Jul 17, 2020 at 16:18:52 +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> >
> > I've tried building RPMs both from the pre-patch tree state and after
> > your patchset. I've then
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> So I was finally able to produce the patches to port libvirt to Meson.
> Obviously, it is a lot of changes. It might look that some of the
> patches could be squashed together but I would rather have it as
> separated as possible to
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> So I was finally able to produce the patches to port libvirt to Meson.
> Obviously, it is a lot of changes. It might look that some of the
> patches could be squashed together but I would rather have it as
> separated as possible to
On Fri, Jul 17, 2020 at 04:04:16PM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
>
> I've tried building RPMs both from the pre-patch tree state and after
> your patchset. I've then extracted all the RPMs toghether and compared
> the file lists (minus
On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
>
> I've tried building RPMs both from the pre-patch tree state and after
> your patchset. I've then extracted all the RPMs toghether and compared
> the file lists (minus the
On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote:
> On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > > > Personally I'd
On Fri, Jul 17, 2020 at 03:02:10PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> > On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > > Personally I'd really like to avoid squashing them, because splitting
> > > up big
On Thu, Jul 16, 2020 at 03:44:25PM +0200, Pavel Hrdina wrote:
> On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> > Personally I'd really like to avoid squashing them, because splitting
> > up big patches is not merely to benefit the initial pre-merge review,
> > but to also
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
I've tried building RPMs both from the pre-patch tree state and after
your patchset. I've then extracted all the RPMs toghether and compared
the file lists (minus the 'build-id' directory which differs).
I'm not sure whether it's due to
On Fri, Jul 17, 2020 at 03:45:36PM +0200, Peter Krempa wrote:
> On Fri, Jul 17, 2020 at 11:39:15 +0200, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> > >
> > > [...]
> > >
> > > Tests fail
On Fri, Jul 17, 2020 at 11:39:15 +0200, Pavel Hrdina wrote:
> On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote:
> > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> >
> > [...]
> >
> > Tests fail when building with clang:
> >
> > built as:
> >
> > CC=clang meson clang
On Fri, Jul 17, 2020 at 12:06:54PM +0200, Ján Tomko wrote:
> On a Friday in 2020, Pavel Hrdina wrote:
> > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
> > >
> > > [...]
> > >
> > > Tests fail when building with
On a Friday in 2020, Pavel Hrdina wrote:
On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote:
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
[...]
Tests fail when building with clang:
built as:
CC=clang meson clang ~/libvirt
cd clang
ninja
ninja test
Looking at
On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
>
> [...]
>
> Tests fail when building with clang:
>
> built as:
>
> CC=clang meson clang ~/libvirt
> cd clang
> ninja
> ninja test
>
>
> Looking at the test output
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
[...]
Tests fail when building with clang:
built as:
CC=clang meson clang ~/libvirt
cd clang
ninja
ninja test
Looking at the test output (pasted below) you didn't faithfully
reproduce the skipping of symbol file tests which have
On Thu, Jul 16, 2020 at 08:36:42PM +0200, Jiri Denemark wrote:
> On Thu, Jul 16, 2020 at 15:47:48 +0200, Pavel Hrdina wrote:
> > On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > > Patches are available in
On Thu, Jul 16, 2020 at 15:47:48 +0200, Pavel Hrdina wrote:
> On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > Patches are available in my Gitlab repo as well:
> > >
> > > git clone -b meson
On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > Patches are available in my Gitlab repo as well:
> >
> > git clone -b meson https://gitlab.com/phrdina/libvirt.git
> >
> > and link to Giltab pipeline:
> >
On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> Patches are available in my Gitlab repo as well:
>
> git clone -b meson https://gitlab.com/phrdina/libvirt.git
>
> and link to Giltab pipeline:
>
> https://gitlab.com/phrdina/libvirt/-/pipelines/167276632
>
> The pipeline
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> So I was finally able to produce the patches to port libvirt to Meson.
> Obviously, it is a lot of changes. It might look that some of the
> patches could be squashed together but I would rather have it as
> separated as possible to
So I was finally able to produce the patches to port libvirt to Meson.
Obviously, it is a lot of changes. It might look that some of the
patches could be squashed together but I would rather have it as
separated as possible to make the review not that difficult.
Once we are done with review I
60 matches
Mail list logo
