Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Laine Stump
On 11/17/20 12:45 PM, Andrea Bolognani wrote: On Tue, 2020-11-17 at 10:47 -0500, Laine Stump wrote: On 11/16/20 11:43 AM, Andrea Bolognani wrote: I don't see how we could possibly not be okay with writing back the updated configuration: filling in whatever blanks are present in the user-provide

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Andrea Bolognani
On Tue, 2020-11-17 at 10:47 -0500, Laine Stump wrote: > On 11/16/20 11:43 AM, Andrea Bolognani wrote: > > I don't see how we could possibly not be okay with writing back the > > updated configuration: filling in whatever blanks are present in the > > user-provided configuration and then writing the

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-17 Thread Laine Stump
On 11/16/20 11:43 AM, Andrea Bolognani wrote: On Mon, 2020-11-16 at 10:00 -0500, Laine Stump wrote: On 11/16/20 5:33 AM, Andrea Bolognani wrote: On Sun, 2020-11-15 at 19:19 -0500, Laine Stump wrote: On 11/15/20 3:43 PM, Andrea Bolognani wrote: We are generating a fresh UUID and storing it in

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-16 Thread Andrea Bolognani
On Mon, 2020-11-16 at 10:00 -0500, Laine Stump wrote: > On 11/16/20 5:33 AM, Andrea Bolognani wrote: > > On Sun, 2020-11-15 at 19:19 -0500, Laine Stump wrote: > > > On 11/15/20 3:43 PM, Andrea Bolognani wrote: > > > > We are generating a fresh UUID and storing it in the XML for the > > > > default

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-16 Thread Laine Stump
On 11/16/20 5:33 AM, Andrea Bolognani wrote: On Sun, 2020-11-15 at 19:19 -0500, Laine Stump wrote: On 11/15/20 3:43 PM, Andrea Bolognani wrote: We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-16 Thread Andrea Bolognani
On Sun, 2020-11-15 at 19:19 -0500, Laine Stump wrote: > On 11/15/20 3:43 PM, Andrea Bolognani wrote: > > We are generating a fresh UUID and storing it in the XML for the > > default network, but this is unnecessary because the network > > driver will automatically generate one if it's missing from

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-16 Thread Daniel P . Berrangé
On Sun, Nov 15, 2020 at 07:19:24PM -0500, Laine Stump wrote: > On 11/15/20 3:43 PM, Andrea Bolognani wrote: > > We are generating a fresh UUID and storing it in the XML for the > > default network, but this is unnecessary because the network > > driver will automatically generate one if it's missin

Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-15 Thread Laine Stump
On 11/15/20 3:43 PM, Andrea Bolognani wrote: We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically generate one if it's missing from the XML; But that automatically generated uuid will not be stor

[libvirt PATCH 1/2] network: Drop UUID handling for default network

2020-11-15 Thread Andrea Bolognani
We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically generate one if it's missing from the XML; the fact that we only do this if the uuidgen command happens to be available on the build machine is fur