Re: [libvirt PATCH 1/2] util: Fix error return for virProcessKillPainfullyDelay()

2023-09-25 Thread Ján Tomko
On a Friday in 2023, Jonathon Jongsma wrote: Commit 93af79fb removed a cleanup label in favor of returning error values directly in certain cases. But the final return value was changed from -1 to 0. If we get to the end of the function, that means that we've waited for the process to exit but it

[libvirt PATCH 1/2] util: Fix error return for virProcessKillPainfullyDelay()

2023-09-22 Thread Jonathon Jongsma
Commit 93af79fb removed a cleanup label in favor of returning error values directly in certain cases. But the final return value was changed from -1 to 0. If we get to the end of the function, that means that we've waited for the process to exit but it still exists. So we should return -1. The erro