Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Jim Fehlig
On 7/23/20 8:59 AM, Daniel P. Berrangé wrote: On Thu, Jul 23, 2020 at 03:08:41PM +0200, Peter Krempa wrote: On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote: On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote: On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote

Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 03:08:41PM +0200, Peter Krempa wrote: > On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote: > > On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote: > > > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote: > > > > btrfs defaults to performing

Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Peter Krempa
On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote: > On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote: > > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote: > > > btrfs defaults to performing copy-on-write for files. This is often > > > undesirable for VM images

Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Peter Krempa
On Thu, Jul 23, 2020 at 14:57:38 +0200, Peter Krempa wrote: > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote: > > btrfs defaults to performing copy-on-write for files. This is often > > undesirable for VM images, so we need to be able to control whether this > > behaviour is used. >

Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Peter Krempa
On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote: > btrfs defaults to performing copy-on-write for files. This is often > undesirable for VM images, so we need to be able to control whether this > behaviour is used. > > The virFileSetCOW() will allow for this. We use a tristate, since

Re: [libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote: > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote: > > btrfs defaults to performing copy-on-write for files. This is often > > undesirable for VM images, so we need to be able to control whether this > > behaviour is used.

[libvirt PATCH 1/4] util: add a helper method for controlling the COW flag on btrfs

2020-07-20 Thread Daniel P . Berrangé
btrfs defaults to performing copy-on-write for files. This is often undesirable for VM images, so we need to be able to control whether this behaviour is used. The virFileSetCOW() will allow for this. We use a tristate, since out of the box, we want the default behaviour attempt to disable cow, bu