Re: [libvirt PATCH 1/9] spec: Simplify setting features off by default

2020-10-06 Thread Andrea Bolognani
On Tue, 2020-10-06 at 07:41 -0400, Neal Gompa wrote: > On Tue, Oct 6, 2020 at 6:09 AM Andrea Bolognani wrote: > > On Mon, 2020-10-05 at 20:42 -0400, Neal Gompa wrote: > > > This crazy setup is an attempt to implement rpm %bcond behavior > > > without actually using %bcond statements. Instead of

Re: [libvirt PATCH 1/9] spec: Simplify setting features off by default

2020-10-06 Thread Neal Gompa
On Tue, Oct 6, 2020 at 6:09 AM Andrea Bolognani wrote: > > On Mon, 2020-10-05 at 20:42 -0400, Neal Gompa wrote: > > On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > > -%define with_fuse 0%{!?_without_fuse:0} > > > -%define with_sanlock 0%{!?_without_sanlock:0} > > >

Re: [libvirt PATCH 1/9] spec: Simplify setting features off by default

2020-10-06 Thread Andrea Bolognani
On Mon, 2020-10-05 at 20:42 -0400, Neal Gompa wrote: > On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > -%define with_fuse 0%{!?_without_fuse:0} > > -%define with_sanlock 0%{!?_without_sanlock:0} > > -%define with_numad 0%{!?_without_numad:0} > > -%define

Re: [libvirt PATCH 1/9] spec: Simplify setting features off by default

2020-10-05 Thread Neal Gompa
On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote: > > The right-hand side of these expressions will always evaluate to > zero. Stop obfuscating this fact. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-)

[libvirt PATCH 1/9] spec: Simplify setting features off by default

2020-10-05 Thread Andrea Bolognani
The right-hand side of these expressions will always evaluate to zero. Stop obfuscating this fact. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index