Re: [libvirt PATCH 13/17] util: extract virStorageFile code into storage_file

2021-01-07 Thread Peter Krempa
On Thu, Jan 07, 2021 at 14:17:04 +0100, Pavel Hrdina wrote: > On Mon, Jan 04, 2021 at 05:43:32PM +0100, Peter Krempa wrote: > > On Mon, Dec 14, 2020 at 16:55:33 +0100, Pavel Hrdina wrote: [...] > Thanks for the explanation for what the functions are used but it > doesn't make it clear to me

Re: [libvirt PATCH 13/17] util: extract virStorageFile code into storage_file

2021-01-07 Thread Pavel Hrdina
On Mon, Jan 04, 2021 at 05:43:32PM +0100, Peter Krempa wrote: > On Mon, Dec 14, 2020 at 16:55:33 +0100, Pavel Hrdina wrote: > > Up until now we had a runtime code and XML related code in the same > > source file inside util directory. > > > > This patch takes the runtime part and extracts it into

Re: [libvirt PATCH 13/17] util: extract virStorageFile code into storage_file

2021-01-04 Thread Peter Krempa
On Mon, Dec 14, 2020 at 16:55:33 +0100, Pavel Hrdina wrote: > Up until now we had a runtime code and XML related code in the same > source file inside util directory. > > This patch takes the runtime part and extracts it into the new > storage_file directory. I like this idea but I'm not a fan