Re: [libvirt PATCH 3/3] syntax-check: Run flake8 on all Python scripts

2021-03-22 Thread Erik Skultety
On Mon, Mar 22, 2021 at 10:29:32AM +0100, Andrea Bolognani wrote: > On Mon, 2021-03-22 at 07:50 +0100, Erik Skultety wrote: > > On Fri, Mar 19, 2021 at 06:39:31PM +0100, Andrea Bolognani wrote: > > > sc_flake8: > > > @if [ -n "$(FLAKE8)" ]; then \ > > > - $(VC_LIST_EXCEPT) | $(GREP)

Re: [libvirt PATCH 3/3] syntax-check: Run flake8 on all Python scripts

2021-03-22 Thread Andrea Bolognani
On Mon, 2021-03-22 at 07:50 +0100, Erik Skultety wrote: > On Fri, Mar 19, 2021 at 06:39:31PM +0100, Andrea Bolognani wrote: > > sc_flake8: > > @if [ -n "$(FLAKE8)" ]; then \ > > - $(VC_LIST_EXCEPT) | $(GREP) '\.py$$' | xargs \ > > - $(FLAKE8) --ignore

Re: [libvirt PATCH 3/3] syntax-check: Run flake8 on all Python scripts

2021-03-22 Thread Erik Skultety
On Fri, Mar 19, 2021 at 06:39:31PM +0100, Andrea Bolognani wrote: > Currenty we only check files that end in .py, but we have at > least a couple of scripts that don't have that suffix and we > nonetheless want to keep compliant with the code style. > > Extend the sc_flake8 syntax-check rule so

[libvirt PATCH 3/3] syntax-check: Run flake8 on all Python scripts

2021-03-19 Thread Andrea Bolognani
Currenty we only check files that end in .py, but we have at least a couple of scripts that don't have that suffix and we nonetheless want to keep compliant with the code style. Extend the sc_flake8 syntax-check rule so that any file that contains a Python 3 shebang is fed to flake8 too.