On Tue, Oct 6, 2020 at 12:35 PM Andrea Bolognani wrote:
>
> On Tue, 2020-10-06 at 08:15 -0400, Neal Gompa wrote:
> > Then can we flip this conditional to %if 0%{?rhel} for the
> > architecture list? As it is, it's unclear that the reason that *RHEL*
> > is the less-capable variant.
>
> Are you
On Tue, 2020-10-06 at 08:15 -0400, Neal Gompa wrote:
> Then can we flip this conditional to %if 0%{?rhel} for the
> architecture list? As it is, it's unclear that the reason that *RHEL*
> is the less-capable variant.
Are you thinking of something like
%define arches_qemu_kvm
On Tue, Oct 6, 2020 at 6:41 AM Andrea Bolognani wrote:
>
> On Mon, 2020-10-05 at 20:40 -0400, Neal Gompa wrote:
> > On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote:
> > > %if 0%{?fedora}
> > > +%define arches_qemu_kvm %{arches_x86} %{power64} s390x %{arm}
> > > aarch64
> > >
On Mon, 2020-10-05 at 20:40 -0400, Neal Gompa wrote:
> On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote:
> > %if 0%{?fedora}
> > +%define arches_qemu_kvm %{arches_x86} %{power64} s390x %{arm}
> > aarch64
> > %else
> > +%define arches_qemu_kvm x86_64 %{power64} aarch64
On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote:
>
> With this commit, all architecture lists that we base feature
> enablement decisions on are defined within a few lines of each
> other, increasing maintainability.
>
> Additionally, generic architecture lists that appear in the
>
On Mon, 2020-10-05 at 20:40 +0200, Andrea Bolognani wrote:
> +++ b/libvirt.spec.in
> @@ -17,10 +17,22 @@
> %define _vpath_builddir %{_target_platform}
> %endif
>
> +%define arches_64bitx86_64 %{power64} aarch64 s390x riscv64
> +%define arches_x86 %{ix86} x86_64
> +
With this commit, all architecture lists that we base feature
enablement decisions on are defined within a few lines of each
other, increasing maintainability.
Additionally, generic architecture lists that appear in the
conditions for multiple features are defined, so that repetition
is reduced.
