Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-10-05 Thread Peter Krempa
On Mon, Oct 05, 2020 at 13:41:52 +0200, Ján Tomko wrote: > On a Monday in 2020, Tim Wiederhake wrote: > > On Wed, 2020-09-30 at 14:11 +0200, Peter Krempa wrote: > > > On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > > > > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > >

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-10-05 Thread Ján Tomko
On a Monday in 2020, Tim Wiederhake wrote: On Wed, 2020-09-30 at 14:11 +0200, Peter Krempa wrote: On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > > Signed-

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-10-04 Thread Tim Wiederhake
On Wed, 2020-09-30 at 14:11 +0200, Peter Krempa wrote: > On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > > > Signed-off-by: Tim Wiederhake > > > > --- >

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-30 Thread Peter Krempa
On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > > Signed-off-by: Tim Wiederhake > > > --- > > > > [...] > > > > > diff --git a/tests/cputestdata/x86_64-bog

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-30 Thread Tim Wiederhake
On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > [...] > > > diff --git a/tests/cputestdata/x86_64-bogus-element.xml > > b/tests/cputestdata/x86_64-bogus-element.xml > > new file m

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-29 Thread Peter Krempa
On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- [...] > diff --git a/tests/cputestdata/x86_64-bogus-element.xml > b/tests/cputestdata/x86_64-bogus-element.xml > new file mode 100644 > index 00..79f98bad18 > --- /dev/null > +++ b/tests/

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-28 Thread Tim Wiederhake
On Mon, 2020-09-28 at 11:20 -0500, Jonathon Jongsma wrote: > (...) > > + > > nickpick: the proper spelling is "existent" > > > > (...) > + > > again. Thanks, fixed locally. I will wait for review on the other patches before resending. Tim

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-28 Thread Jonathon Jongsma
On Mon, 2020-09-21 at 15:07 +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > tests/cputest.c | 4 > tests/cputestdata/x86_64-bogus-attribute.xml | 2 ++ > tests/cputestdata/x86_64-bogus-element.xml | 3 +++ > 3 files changed, 9 insertions(+)

[libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

2020-09-21 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- tests/cputest.c | 4 tests/cputestdata/x86_64-bogus-attribute.xml | 2 ++ tests/cputestdata/x86_64-bogus-element.xml | 3 +++ 3 files changed, 9 insertions(+) create mode 100644 tests/cputestdata/x86_64-bogus-attribute.xml cr