Re: [PATCH] virtlogd: solve some memory leaks

2020-06-17 Thread Ján Tomko
On a Tuesday in 2020, wangjian wrote: We used asan to find some memory leaks in virtlogd. In the virThreadPoolFree function, When job->data is of type virNetServerJobPtr, the following memory leak problem exists. 1. job->data is not released Direct leak of 24 byte(s) in 1 object(s) allocated

Re: [PATCH] virtlogd: solve some memory leaks

2020-06-17 Thread Michal Privoznik
On 6/17/20 9:58 AM, wangjian (AN) wrote: 1. Yes, our testers opened some compilation options, such as -fsanitizer=leak. 2. The version of libvirt we are using is 3.2.0. Our tester deployed a long-lived environment and did many operations (he didn't remember what he did), such as restarting

RE: [PATCH] virtlogd: solve some memory leaks

2020-06-17 Thread wangjian (AN)
virtual machines, kill -9 virtlogd, libvirtd, etc. -Original Message- From: Michal Privoznik [mailto:mpriv...@redhat.com] Sent: Tuesday, June 16, 2020 9:58 PM To: wangjian (AN) Cc: libvir-list@redhat.com Subject: Re: [PATCH] virtlogd: solve some memory leaks On 6/16/20 8:26 AM, wangjian

Re: [PATCH] virtlogd: solve some memory leaks

2020-06-16 Thread Michal Privoznik
On 6/16/20 8:26 AM, wangjian wrote: We used asan to find some memory leaks in virtlogd. In the virThreadPoolFree function, When job->data is of type virNetServerJobPtr, the following memory leak problem exists. 1. job->data is not released Direct leak of 24 byte(s) in 1 object(s) allocated

Re: [PATCH] virtlogd: solve some memory leaks

2020-06-16 Thread Andrea Bolognani
On Tue, 2020-06-16 at 14:26 +0800, wangjian wrote: > We used asan to find some memory leaks in virtlogd. In the virThreadPoolFree > function, > When job->data is of type virNetServerJobPtr, the following memory leak > problem exists. Please don't CC random developers when posting patches, or