Re: [PATCH] conf: force 8 byte alignment for virObjectEvent

2020-06-05 Thread Michal Privoznik
On 6/3/20 12:22 PM, Daniel P. Berrangé wrote: We need to be able to cast from virObjectEventPtr to one of its many subclasses. Some of these subclasses have 8 byte alignment on 32-bit platforms, but virObjectEventPtr only has 4 byte alignment. Previously the virObject base class had 8 byte

Re: [PATCH] conf: force 8 byte alignment for virObjectEvent

2020-06-03 Thread Rafael Fonseca
On Wed, Jun 3, 2020 at 12:29 PM Daniel P. Berrangé wrote: > > We need to be able to cast from virObjectEventPtr to one of > its many subclasses. Some of these subclasses have 8 byte > alignment on 32-bit platforms, but virObjectEventPtr only > has 4 byte alignment. > > Previously the virObject

Re: [PATCH] conf: force 8 byte alignment for virObjectEvent

2020-06-03 Thread Eric Blake
On 6/3/20 5:22 AM, Daniel P. Berrangé wrote: Forcing 8-byte alignment on virObjectEventPtr removes the alignment increase during casts to subclasses. Signed-off-by: Daniel P. Berrangé --- Technically a build-breaker, but since we don't have any existing usage of __attribute__((aligned)), I

Re: [PATCH] conf: force 8 byte alignment for virObjectEvent

2020-06-03 Thread Pavel Hrdina
On Wed, Jun 03, 2020 at 11:22:47AM +0100, Daniel P. Berrangé wrote: > We need to be able to cast from virObjectEventPtr to one of > its many subclasses. Some of these subclasses have 8 byte > alignment on 32-bit platforms, but virObjectEventPtr only > has 4 byte alignment. > > Previously the