Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Matthias Bolte
2010/4/27 Stefan Berger stef...@us.ibm.com: libvir-list-boun...@redhat.com wrote on 04/26/2010 03:20:47 PM: static struct sigaction zero_sigaction = {0}; struct sigaction action_stop = zero_sigaction; action_stop.sa_handler = stop; But don't go changing this commit just for that

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Daniel P. Berrange
On Mon, Apr 26, 2010 at 06:46:31PM -0400, Stefan Berger wrote: libvir-list-boun...@redhat.com wrote on 04/26/2010 03:20:47 PM: static struct sigaction zero_sigaction = {0}; struct sigaction action_stop = zero_sigaction; action_stop.sa_handler = stop; But don't go changing this

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Stefan Berger
Matthias Bolte matthias.bo...@googlemail.com wrote on 04/27/2010 04:03:54 AM: 2010/4/27 Stefan Berger stef...@us.ibm.com: [...] I just pushed a patch to fix this. Got the git update now and your build fix. virsh works for me. I tested it with a connection to a remote libvirtd using

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Eric Blake
On 04/27/2010 07:00 AM, Stefan Berger wrote: virsh works for me. I tested it with a connection to a remote libvirtd using a plain unencrypted TCP connection: virsh -c qemu+tcp://server/system Not the same luck here. I still see it aborting. Also the 'make check' test-poll doesn't succeed

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Daniel Veillard
On Sun, Apr 25, 2010 at 01:32:32PM +0200, Matthias Bolte wrote: --- examples/domain-events/events-c/event-test.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/domain-events/events-c/event-test.c b/examples/domain-events/events-c/event-test.c index

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Eric Blake
On 04/25/2010 05:32 AM, Matthias Bolte wrote: --- examples/domain-events/events-c/event-test.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/domain-events/events-c/event-test.c b/examples/domain-events/events-c/event-test.c index 53a3195..74eabba

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Matthias Bolte
2010/4/26 Eric Blake ebl...@redhat.com: On 04/25/2010 05:32 AM, Matthias Bolte wrote: ---  examples/domain-events/events-c/event-test.c |    7 ---  1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/domain-events/events-c/event-test.c

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Eric Blake
On 04/26/2010 01:20 PM, Matthias Bolte wrote: ACK. By the way, the for some reason boils down to how sa_handler is declared in signal.h on the two platforms. On cygwin, sa_handler happens to be a member of an anonymous union (exploiting a gcc extension); whereas on Linux, it is a macro that

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Matthias Bolte
2010/4/26 Eric Blake ebl...@redhat.com: On 04/26/2010 01:20 PM, Matthias Bolte wrote: ACK.  By the way, the for some reason boils down to how sa_handler is declared in signal.h on the two platforms.  On cygwin, sa_handler happens to be a member of an anonymous union (exploiting a gcc

Re: [libvirt] [PATCH] Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 04/26/2010 03:20:47 PM: static struct sigaction zero_sigaction = {0}; struct sigaction action_stop = zero_sigaction; action_stop.sa_handler = stop; But don't go changing this commit just for that theoretical platform. Thanks, pushed. Does