Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 415bfd87e0ecd7751ed6df372e82da0e3991d617 # Parent

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 10:55:37AM +, Richard W.M. Jones wrote: Does XenD actaully persist the schedinfo changes for inactive domains ? Historically we've only considered the sched tunables API to be relevant to active guests, and none of the drivers make any attempt to persist the

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 10:55:37AM +, Richard W.M. Jones wrote: On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 11:29:01AM +, Daniel P. Berrange wrote: It isn't that simple. Tunables are not represented as part of the XML, Good point, that would need to be fixed. I'd missed this. So if we want to be able to set tunables on inactive domains, the

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 11:48:42AM +, John Levon wrote: On Mon, Jan 26, 2009 at 11:29:01AM +, Daniel P. Berrange wrote: It isn't that simple. Tunables are not represented as part of the XML, Good point, that would need to be fixed. I'd missed this. So if we want to be able to

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 12:28:47PM +, Richard W.M. Jones wrote: No, surely we should fix the XML to represent it, and then it /would/ work. Must be better than another identical API. Historically there has been a bit of a debate about this. It's not clear if the XML is meant to

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-26 Thread Richard W.M. Jones
On Mon, Jan 26, 2009 at 01:21:46PM +, John Levon wrote: On Mon, Jan 26, 2009 at 12:28:47PM +, Richard W.M. Jones wrote: No, surely we should fix the XML to represent it, and then it /would/ work. Must be better than another identical API. Historically there has been a bit of

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-23 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 415bfd87e0ecd7751ed6df372e82da0e3991d617 # Parent 68e14fe50dfa88a4694bc4c7a68d2f73f41c6171 Fix virsh sched-credit for xend Need to pass

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-23 Thread John Levon
On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: Fix virsh sched-credit for xend Need to pass domain in the xend op for shut-down domains. (This also requires xend fixes, but this patch doesn't make things worse.) Does XenD actaully persist the schedinfo changes