Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander mklet...@redhat.com wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Eric Blake wrote: On 07/23/2012 12:51 PM, Martin Kletzander wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) In

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/24/2012 09:58 AM, Daniel P. Berrange wrote: On Tue, Jul 24, 2012 at 09:16:38AM +0200, Martin Kletzander wrote: On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-23 Thread Doug Goldstein
On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander mklet...@redhat.com wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-23 Thread Eric Blake
On 07/23/2012 12:51 PM, Martin Kletzander wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) In addition to Doug's review... -doc =

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-23 Thread Daniel P. Berrange
On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander mklet...@redhat.com wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1