Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

> On 17 Oct 2019, at 14:35, Cole Robinson wrote: > > Hmm why wasn't I in to/cc list, was that intentional? Not at all. I assumed a reply-to would add it automatically and did not bother checking. Probably something wrong in my mu4e config. > > On 10/17/19 5:26 AM, Christophe de Dinechin

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

Hmm why wasn't I in to/cc list, was that intentional? On 10/17/19 5:26 AM, Christophe de Dinechin wrote: > > Cole Robinson writes: > >> This series is the first steps to teaching libvirt about qcow2 >> data_file support, aka external data files or qcow2 external metadata. >> >> A bit about the

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

Cole Robinson writes: > This series is the first steps to teaching libvirt about qcow2 > data_file support, aka external data files or qcow2 external metadata. > > A bit about the feature: it was added in qemu 4.0. It essentially > creates a two part image file: a qcow2 layer that just tracks

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On Wed, Oct 16, 2019 at 1:04 AM Cole Robinson wrote: > On 10/15/19 3:56 AM, Han Han wrote: > > Hello Cole, one issue is found: > > The qcow2 data file XTTRs is not cleaned on external snapshot when > > -blockdev is not enabled > > > > Versions: > > libvirt v5.8.0-134-g9d03e9adf1 > >

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/15/19 3:56 AM, Han Han wrote: > Hello Cole, one issue is found: > The qcow2 data file XTTRs is not cleaned on external snapshot when > -blockdev is not enabled > > Versions: > libvirt v5.8.0-134-g9d03e9adf1 > qemu-kvm-4.1.0-13.module+el8.1.0+4313+ef76ec61.x86_64 > > Steps: > 1. Convert a

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/15/19 12:29 AM, Han Han wrote: > I find the issue cannot reproduced when `make clean` before build the > source. > It is not proper to build with an unclean source dir, right? > I don't use 'make clean' in libvirt.git but in other projects I have hit issues that required 'make clean', like

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

I find the issue cannot reproduced when `make clean` before build the source. It is not proper to build with an unclean source dir, right? On Tue, Oct 15, 2019 at 3:55 AM Cole Robinson wrote: > On 10/12/19 11:07 AM, Han Han wrote: > > > > > > On Sat, Oct 12, 2019 at 1:05 AM Cole Robinson >

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/12/19 11:07 AM, Han Han wrote: > > > On Sat, Oct 12, 2019 at 1:05 AM Cole Robinson > wrote: > > On 10/10/19 11:25 PM, Han Han wrote: > > Hi Cole, > > I merged crobinso/qcow2-data_file branch to 37b565c00. Reserved new > > capabilities

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On Sat, Oct 12, 2019 at 1:05 AM Cole Robinson wrote: > On 10/10/19 11:25 PM, Han Han wrote: > > Hi Cole, > > I merged crobinso/qcow2-data_file branch to 37b565c00. Reserved new > > capabilities introduced by these to branches to resolve conflicts. > > Then build and test as following: > > #

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/11/19 9:45 AM, Ján Tomko wrote: On Mon, Oct 07, 2019 at 05:49:14PM -0400, Cole Robinson wrote: This series is the first steps to teaching libvirt about qcow2 data_file support, aka external data files or qcow2 external metadata. A bit about the feature: it was added in qemu 4.0. It

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/10/19 11:25 PM, Han Han wrote: Hi Cole, I merged crobinso/qcow2-data_file branch to 37b565c00. Reserved new capabilities introduced by these to branches to resolve conflicts. Then build and test as following: # ./autogen.sh&& ./configure --without-libssh --build=x86_64-redhat-linux-gnu

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On Mon, Oct 07, 2019 at 05:49:14PM -0400, Cole Robinson wrote: This series is the first steps to teaching libvirt about qcow2 data_file support, aka external data files or qcow2 external metadata. A bit about the feature: it was added in qemu 4.0. It essentially creates a two part image file: a

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/7/19 11:49 PM, Cole Robinson wrote: This series is the first steps to teaching libvirt about qcow2 data_file support, aka external data files or qcow2 external metadata. A bit about the feature: it was added in qemu 4.0. It essentially creates a two part image file: a qcow2 layer that

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

Hi Cole, I merged crobinso/qcow2-data_file branch to 37b565c00. Reserved new capabilities introduced by these to branches to resolve conflicts. Then build and test as following: # ./autogen.sh&& ./configure --without-libssh --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

Hi, ACKed basically everything, perhaps one or two patches I found something worth talking about but nothing too gamebreaker. Logic-wise everything made sense to me, but I believe someone else with a deeper understanding of the storage backend in Libvirt might know better. I am not sure how

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On 10/8/19 1:52 AM, Christian Ehrhardt wrote: On Mon, Oct 7, 2019 at 11:49 PM Cole Robinson wrote: This series is the first steps to teaching libvirt about qcow2 data_file support, aka external data files or qcow2 external metadata. A bit about the feature: it was added in qemu 4.0. It

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On Mon, Oct 7, 2019 at 11:49 PM Cole Robinson wrote: > > This series is the first steps to teaching libvirt about qcow2 > data_file support, aka external data files or qcow2 external metadata. > > A bit about the feature: it was added in qemu 4.0. It essentially > creates a two part image file: a