Re: [libvirt] [PATCH 1/6] s390: Cpu driver support for update and compare

2016-12-07 Thread Jiri Denemark
On Tue, Dec 06, 2016 at 17:14:07 -0500, Jason J. Herne wrote: > On 11/28/2016 04:55 AM, Jiri Denemark wrote: > ... > > > +static virCPUCompareResult > > > +virCPUs390Compare(virCPUDefPtr host ATTRIBUTE_UNUSED, > > > + virCPUDefPtr cpu ATTRIBUTE_UNUSED, > > > + bool

Re: [libvirt] [PATCH 1/6] s390: Cpu driver support for update and compare

2016-12-06 Thread Jason J. Herne
On 11/28/2016 04:55 AM, Jiri Denemark wrote: ... +static virCPUCompareResult +virCPUs390Compare(virCPUDefPtr host ATTRIBUTE_UNUSED, + virCPUDefPtr cpu ATTRIBUTE_UNUSED, + bool failMessages ATTRIBUTE_UNUSED) The indentation is a bit off here. +{ +return

Re: [libvirt] [PATCH 1/6] s390: Cpu driver support for update and compare

2016-11-28 Thread Jiri Denemark
On Mon, Nov 21, 2016 at 14:11:51 -0500, Jason J. Herne wrote: > Implement compare for s390. Required to test the guest against the host for > guest cpu model runnability checking. We always return IDENTICAL to bypass > Libvirt's checking. s390 will rely on Qemu to perform the runnability >