Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-16 Thread Ilias Stamatis
On Thu, May 16, 2019 at 9:44 AM Michal Privoznik wrote: > > On 5/15/19 11:49 AM, Ilias Stamatis wrote: > > On Wed, May 15, 2019 at 10:14 AM Michal Privoznik > > wrote: > >> > >> On 5/14/19 5:24 PM, Ilias Stamatis wrote: > >>> On Tue, May 14, 2019 at 5:04 PM Michal Privoznik > >>> wrote: >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-16 Thread Michal Privoznik
On 5/15/19 11:49 AM, Ilias Stamatis wrote: On Wed, May 15, 2019 at 10:14 AM Michal Privoznik wrote: On 5/14/19 5:24 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 5:04 PM Michal Privoznik wrote: On 5/14/19 12:50 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 12:40 PM John Ferlan

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-15 Thread Ilias Stamatis
On Wed, May 15, 2019 at 10:14 AM Michal Privoznik wrote: > > On 5/14/19 5:24 PM, Ilias Stamatis wrote: > > On Tue, May 14, 2019 at 5:04 PM Michal Privoznik > > wrote: > >> > >> On 5/14/19 12:50 PM, Ilias Stamatis wrote: > >>> On Tue, May 14, 2019 at 12:40 PM John Ferlan wrote: > > >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-15 Thread Peter Krempa
On Wed, May 15, 2019 at 10:14:35 +0200, Michal Privoznik wrote: > On 5/14/19 5:24 PM, Ilias Stamatis wrote: > > On Tue, May 14, 2019 at 5:04 PM Michal Privoznik > > wrote: [...] > > Because in the first loop, VIR_STRDUP might fail and send us to > > "cleanup". But then on cleanup we iterate

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-15 Thread Michal Privoznik
On 5/14/19 5:24 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 5:04 PM Michal Privoznik wrote: On 5/14/19 12:50 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 12:40 PM John Ferlan wrote: On 5/13/19 9:04 AM, Ilias Stamatis wrote: On Mon, May 13, 2019 at 2:38 PM Michal Privoznik

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-14 Thread Ilias Stamatis
On Tue, May 14, 2019 at 5:04 PM Michal Privoznik wrote: > > On 5/14/19 12:50 PM, Ilias Stamatis wrote: > > On Tue, May 14, 2019 at 12:40 PM John Ferlan wrote: > >> > >> > >> > >> On 5/13/19 9:04 AM, Ilias Stamatis wrote: > >>> On Mon, May 13, 2019 at 2:38 PM Michal Privoznik > >>> wrote: >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-14 Thread Michal Privoznik
On 5/14/19 12:50 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 12:40 PM John Ferlan wrote: On 5/13/19 9:04 AM, Ilias Stamatis wrote: On Mon, May 13, 2019 at 2:38 PM Michal Privoznik wrote: On 5/13/19 1:26 AM, Ilias Stamatis wrote: Return the number of disks present in the

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-14 Thread Ilias Stamatis
On Tue, May 14, 2019 at 12:40 PM John Ferlan wrote: > > > > On 5/13/19 9:04 AM, Ilias Stamatis wrote: > > On Mon, May 13, 2019 at 2:38 PM Michal Privoznik > > wrote: > >> > >> On 5/13/19 1:26 AM, Ilias Stamatis wrote: > >>> Return the number of disks present in the configuration of the test >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-14 Thread John Ferlan
On 5/13/19 9:04 AM, Ilias Stamatis wrote: > On Mon, May 13, 2019 at 2:38 PM Michal Privoznik wrote: >> >> On 5/13/19 1:26 AM, Ilias Stamatis wrote: >>> Return the number of disks present in the configuration of the test >>> domain when called with @errors as NULL and @maxerrors as 0. >>> >>>

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-13 Thread Ilias Stamatis
On Mon, May 13, 2019 at 2:38 PM Michal Privoznik wrote: > > On 5/13/19 1:26 AM, Ilias Stamatis wrote: > > Return the number of disks present in the configuration of the test > > domain when called with @errors as NULL and @maxerrors as 0. > > > > Otherwise report an error for every second disk,

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-13 Thread Michal Privoznik
On 5/13/19 1:26 AM, Ilias Stamatis wrote: Return the number of disks present in the configuration of the test domain when called with @errors as NULL and @maxerrors as 0. Otherwise report an error for every second disk, assigning available error codes in a cyclic order. Signed-off-by: Ilias